Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[@kadena/cli] Implement max time option for simulate #1476

Merged
merged 14 commits into from
Feb 2, 2024

Conversation

nil-amrutlal
Copy link
Contributor

@nil-amrutlal nil-amrutlal commented Jan 15, 2024

This PR contains an additional flag for max time for the simulation command

Copy link

changeset-bot bot commented Jan 15, 2024

🦋 Changeset detected

Latest commit: 0adcdc8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@kadena/kadena-cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Jan 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
alpha-docs ✅ Ready (Inspect) Visit Preview Feb 1, 2024 10:10am
react-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 1, 2024 10:10am
tools ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 1, 2024 10:10am
2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
docs-storybook ⬜️ Ignored (Inspect) Visit Preview Feb 1, 2024 10:10am
proof-of-us ⬜️ Ignored (Inspect) Visit Preview Feb 1, 2024 10:10am

@nil-amrutlal nil-amrutlal marked this pull request as ready for review January 15, 2024 15:52
Copy link
Contributor

@nillo nillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Please also remove the .gitkeep file from the PR
  • I didnt take a dive into the actual functionality of what simulate is doing, @alber70g you know what this is for, maybe you can take a look at this PR also

packages/tools/kadena-cli/src/devnet/commands/simulate.ts Outdated Show resolved Hide resolved
packages/tools/kadena-cli/src/utils/globalOptions.ts Outdated Show resolved Hide resolved
Base automatically changed from feat/kadena-cli/devnet-simulation to main February 1, 2024 09:56
@nil-amrutlal nil-amrutlal merged commit c4e0e6d into main Feb 2, 2024
15 checks passed
@nil-amrutlal nil-amrutlal deleted the feat/kadena-cli/simulate-aditional-parameters branch February 2, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants