Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/use alias in forms #2705

Merged
merged 5 commits into from
Dec 2, 2024
Merged

Feat/use alias in forms #2705

merged 5 commits into from
Dec 2, 2024

Conversation

javadkh2
Copy link
Collaborator

@javadkh2 javadkh2 commented Dec 2, 2024

Modify this title

Related Issue/Asana ticket: _

Short description: _

Test scenarios

  • description of the (manually) executed test scenarios

Reminders (if applicable)

  • I ran pnpm install and pnpm test in the root of the monorepo
    (optionally with --filter=...package... to exclude non-affected
    projects)
  • I ran pnpm changeset in the root of the monorepo
  • Test coverage has not decreased
  • Docs have been updated to reflect changes in PR (don't forget
    docs.kadena.io)

Copy link

changeset-bot bot commented Dec 2, 2024

⚠️ No Changeset found

Latest commit: 9301530

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Dec 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dev-wallet ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 2, 2024 9:13pm
rwa-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 2, 2024 9:13pm
6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
alpha-docs ⬜️ Ignored (Inspect) Visit Preview 💬 Add feedback Dec 2, 2024 9:13pm
kode-ui ⬜️ Ignored (Inspect) Visit Preview Dec 2, 2024 9:13pm
explorer ⬜️ Skipped (Inspect) Dec 2, 2024 9:13pm
marmalade-marketplace ⬜️ Skipped (Inspect) Dec 2, 2024 9:13pm
proof-of-us ⬜️ Skipped (Inspect) Dec 2, 2024 9:13pm
tools ⬜️ Skipped (Inspect) Dec 2, 2024 9:13pm

@@ -0,0 +1,30 @@
import { useLayout } from '@kadena/kode-ui/patterns';
import { useEffect, useState } from 'react';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! this is a fix I need to do for kode UI as well

@vercel vercel bot temporarily deployed to Preview – tools December 2, 2024 21:10 Inactive
@vercel vercel bot temporarily deployed to Preview – proof-of-us December 2, 2024 21:10 Inactive
@vercel vercel bot temporarily deployed to Preview – explorer December 2, 2024 21:10 Inactive
@vercel vercel bot temporarily deployed to Preview – marmalade-marketplace December 2, 2024 21:10 Inactive
@javadkh2 javadkh2 merged commit 021119c into main Dec 2, 2024
17 of 18 checks passed
@javadkh2 javadkh2 deleted the feat/use-alias-in-forms branch December 2, 2024 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants