Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(docs): implement storybook for layout components #825

Merged
merged 17 commits into from
Sep 1, 2023

Conversation

realdreamer
Copy link
Contributor

Closes : https://app.asana.com/0/1205288273408141/1205310320676421/f

This PR adds the storybook for the following layout types

  • Blog
  • Landing
  • Redocly
  • Full

As part of this story figured out that having storybook for Home component doesn't makes sense. Since, as part of Home everything is just a children

@vercel
Copy link

vercel bot commented Aug 28, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

5 Ignored Deployments
Name Status Preview Comments Updated (UTC)
alpha-docs ⬜️ Ignored (Inspect) Visit Preview Sep 1, 2023 10:32am
docs-storybook ⬜️ Ignored (Inspect) Visit Preview Sep 1, 2023 10:32am
immutable-records ⬜️ Ignored (Inspect) Visit Preview Sep 1, 2023 10:32am
react-ui ⬜️ Ignored (Inspect) Visit Preview Sep 1, 2023 10:32am
tools ⬜️ Ignored (Inspect) Visit Preview Sep 1, 2023 10:32am

@changeset-bot
Copy link

changeset-bot bot commented Aug 28, 2023

🦋 Changeset detected

Latest commit: 2e91afd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@realdreamer realdreamer force-pushed the feat/layouts-storybook branch 2 times, most recently from f0a17b4 to 7069fab Compare September 1, 2023 09:04
@realdreamer realdreamer force-pushed the feat/layouts-storybook branch from b94c008 to 2e91afd Compare September 1, 2023 10:31
Copy link
Contributor

@webpro webpro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@realdreamer realdreamer merged commit 9b5d86e into main Sep 1, 2023
6 checks passed
@realdreamer realdreamer deleted the feat/layouts-storybook branch September 1, 2023 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants