-
-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consumers: Unsubscribe topics from consumer group #549
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi p-eye! 👋
Welcome, and thank you for opening your first PR in the repo!
Please wait for triaging by our maintainers.
Please take a look at our contributing guide.
@Haarolean Do you think the review might take a bit longer? |
it definitely will as I'm trying to wrap the things up for 1.1 release, while the other folks seem to be busy for a review :-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor thing regarding delete -> reset naming, the rest (backend) looks good 👍🏼
In addition, I removed unused imports. |
@p-eye thank you for one more contribution! |
What changes did you make? (Give an overview)
As mentioned in issue #462, on the consumer group page, add a button to delete topic offsets. It should function similarly to the following command:
Is there anything you'd like reviewers to focus on?
How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)
Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)
Check out Contributing and Code of Conduct
A picture of a cute animal (not mandatory but encouraged)