Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consumers: Unsubscribe topics from consumer group #549

Merged
merged 10 commits into from
Oct 9, 2024

Conversation

p-eye
Copy link
Contributor

@p-eye p-eye commented Sep 17, 2024

  • Breaking change? (if so, please describe the impact and migration path for existing application instances)

What changes did you make? (Give an overview)
As mentioned in issue #462, on the consumer group page, add a button to delete topic offsets. It should function similarly to the following command:

kafka-consumer-groups --bootstrap-server <server>
   --delete-offsets -group <group_name> \
   --topic <topic_1>
image

Is there anything you'd like reviewers to focus on?

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

  • No need to
  • Manually (please, describe, if necessary)
  • Unit checks
  • Integration checks
  • Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings (e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Check out Contributing and Code of Conduct

A picture of a cute animal (not mandatory but encouraged)

@p-eye p-eye requested review from a team as code owners September 17, 2024 08:12
@kapybro kapybro bot added status/triage Issues pending maintainers triage status/triage/manual Manual triage in progress area/consumers area/topics status/triage/completed Automatic triage completed and removed status/triage Issues pending maintainers triage labels Sep 17, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi p-eye! 👋

Welcome, and thank you for opening your first PR in the repo!

Please wait for triaging by our maintainers.

Please take a look at our contributing guide.

@Haarolean Haarolean added type/enhancement En enhancement/improvement to an already existing feature scope/frontend Related to frontend changes scope/backend Related to backend changes and removed area/topics status/triage/manual Manual triage in progress labels Sep 18, 2024
@Haarolean Haarolean self-assigned this Sep 18, 2024
@Haarolean Haarolean linked an issue Sep 18, 2024 that may be closed by this pull request
2 tasks
@Haarolean Haarolean changed the title (Issues 462) Consumers: Unsubscribe topics from consumer group Consumers: Unsubscribe topics from consumer group Sep 18, 2024
@p-eye
Copy link
Contributor Author

p-eye commented Sep 24, 2024

@Haarolean Do you think the review might take a bit longer?
I would appreciate it if your team could review it.
thanks 😃

@Haarolean
Copy link
Member

@Haarolean Do you think the review might take a bit longer? I would appreciate it if your team could review it. thanks 😃

it definitely will as I'm trying to wrap the things up for 1.1 release, while the other folks seem to be busy for a review :-)

@Haarolean Haarolean added this to the 1.2 milestone Sep 27, 2024
@Haarolean Haarolean added the hacktoberfest-accepted PRs accepted towards hacktoberfest goal and will be counted as approved label Oct 4, 2024
Copy link
Member

@Haarolean Haarolean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor thing regarding delete -> reset naming, the rest (backend) looks good 👍🏼

@Haarolean Haarolean assigned p-eye and unassigned Haarolean Oct 4, 2024
@Haarolean Haarolean self-requested a review October 6, 2024 18:51
@Haarolean Haarolean requested review from a team and removed request for iliax and Mgrdich October 6, 2024 21:50
@p-eye
Copy link
Contributor Author

p-eye commented Oct 7, 2024

In addition, I removed unused imports.

@Haarolean Haarolean merged commit f36c18d into kafbat:main Oct 9, 2024
10 of 13 checks passed
@Haarolean
Copy link
Member

@p-eye thank you for one more contribution!

@Haarolean Haarolean removed this from the 1.1 milestone Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/consumers hacktoberfest-accepted PRs accepted towards hacktoberfest goal and will be counted as approved scope/backend Related to backend changes scope/frontend Related to frontend changes status/triage/completed Automatic triage completed type/enhancement En enhancement/improvement to an already existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consumers: Unsubscribe topics from consumer group
4 participants