-
-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BE: ACL: Consumers preset now include DESCRIBE permission for CG #593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kapybro
bot
added
status/triage
Issues pending maintainers triage
status/triage/manual
Manual triage in progress
area/acl
status/triage/completed
Automatic triage completed
and removed
status/triage
Issues pending maintainers triage
labels
Oct 8, 2024
4 tasks
Haarolean
added
hacktoberfest
Issues good for hacktoberfest goal
hacktoberfest-accepted
PRs accepted towards hacktoberfest goal and will be counted as approved
scope/backend
Related to backend changes
type/bug
Something isn't working
and removed
status/triage/manual
Manual triage in progress
hacktoberfest
Issues good for hacktoberfest goal
labels
Oct 8, 2024
@polegkashti PTAL at the build, there are a few tests failing |
…into issues/592 Change author name
…into issues/592
I fixed it; the issue was caused because the tests didn't expect the DESCRIBE ACL for consumer groups :) |
Haarolean
approved these changes
Oct 18, 2024
Haarolean
changed the title
Add DESCRIBE permission by default for consumer groups in ACL service
BE: ACL: Consumers preset now include DESCRIBE permission for CG
Oct 18, 2024
@polegkashti thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/acl
hacktoberfest-accepted
PRs accepted towards hacktoberfest goal and will be counted as approved
scope/backend
Related to backend changes
status/triage/completed
Automatic triage completed
type/bug
Something isn't working
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes did you make? (Give an overview)
I modified the ACL service to automatically include the
DESCRIBE
permission when creating an ACL for consumer groups. This ensures that consumer groups have bothREAD
andDESCRIBE
permissions by default, preventing common authorization errors that occur when onlyREAD
is assigned.This change addresses the issue where users frequently encounter "Group authorization denied" errors and have to manually add a DESCRIBE ACL. With this fix, the ACLs are more functional out of the box.
Is there anything you'd like reviewers to focus on?
How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)
Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)
Check out Contributing and Code of Conduct
A picture of a cute animal (not mandatory but encouraged)