Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BE: ACL: Consumers preset now include DESCRIBE permission for CG #593

Merged
merged 7 commits into from
Oct 18, 2024

Conversation

polegkashti
Copy link
Contributor

  • Breaking change? (if so, please describe the impact and migration path for existing application instances)

What changes did you make? (Give an overview)
I modified the ACL service to automatically include the DESCRIBE permission when creating an ACL for consumer groups. This ensures that consumer groups have both READ and DESCRIBE permissions by default, preventing common authorization errors that occur when only READ is assigned.

This change addresses the issue where users frequently encounter "Group authorization denied" errors and have to manually add a DESCRIBE ACL. With this fix, the ACLs are more functional out of the box.
Is there anything you'd like reviewers to focus on?

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

  • No need to
  • Manually (please, describe, if necessary)
  • Unit checks
  • Integration checks
  • Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings (e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Check out Contributing and Code of Conduct

A picture of a cute animal (not mandatory but encouraged)

@polegkashti polegkashti requested a review from a team as a code owner October 8, 2024 19:08
@kapybro kapybro bot added status/triage Issues pending maintainers triage status/triage/manual Manual triage in progress area/acl status/triage/completed Automatic triage completed and removed status/triage Issues pending maintainers triage labels Oct 8, 2024
@Haarolean Haarolean linked an issue Oct 8, 2024 that may be closed by this pull request
4 tasks
@Haarolean Haarolean added hacktoberfest Issues good for hacktoberfest goal hacktoberfest-accepted PRs accepted towards hacktoberfest goal and will be counted as approved scope/backend Related to backend changes type/bug Something isn't working and removed status/triage/manual Manual triage in progress hacktoberfest Issues good for hacktoberfest goal labels Oct 8, 2024
@Haarolean
Copy link
Member

@polegkashti PTAL at the build, there are a few tests failing

@polegkashti
Copy link
Contributor Author

@polegkashti PTAL at the build, there are a few tests failing

I fixed it; the issue was caused because the tests didn't expect the DESCRIBE ACL for consumer groups :)

@Haarolean Haarolean modified the milestone: 1.1 Oct 18, 2024
@Haarolean Haarolean changed the title Add DESCRIBE permission by default for consumer groups in ACL service BE: ACL: Consumers preset now include DESCRIBE permission for CG Oct 18, 2024
@Haarolean Haarolean merged commit c8a8759 into kafbat:main Oct 18, 2024
11 of 13 checks passed
@Haarolean
Copy link
Member

@polegkashti thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/acl hacktoberfest-accepted PRs accepted towards hacktoberfest goal and will be counted as approved scope/backend Related to backend changes status/triage/completed Automatic triage completed type/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ACL: Consumers preset should include DESCRIBE permission for CG
2 participants