Merge pull request #22 from kaigu1990/up_v1.1.1

Prepare the resubmission of mcradds to v1.1.1
kaigu1990 · Aug 27, 2024 · 2c19dc1 · 2c19dc1
2 parents 893e965 + 673ceb7
commit 2c19dc1
Show file tree

Hide file tree

Showing 11 changed files with 25 additions and 36 deletions.
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -1,7 +1,7 @@
 Package: mcradds
 Type: Package
 Title: Processing and Analyzing of Diagnostics Trials
-Version: 1.1.0
+Version: 1.1.1
 Authors@R: c(
     person("Kai", "Gu", , "gukai1212@163.com", role = c("aut", "cre", "cph"))
     )
@@ -47,7 +47,7 @@ Suggests:
 Config/testthat/edition: 3
 VignetteBuilder: knitr
 Roxygen: list(markdown = TRUE)
-RoxygenNote: 7.2.3
+RoxygenNote: 7.3.1
 Collate: 
     'pkg_class.R'
     'pkg_methods.R'

diff --git a/NEWS.md b/NEWS.md
@@ -1,3 +1,7 @@
+# mcradds 1.1.1
+
+* Fix the `autoplot` test error due to ggplot dependence update.
+
 # mcradds 1.1.0
 
 ### Enhancements

diff --git a/R/autoplot.R b/R/autoplot.R
@@ -459,7 +459,8 @@ setMethod(
     p +
       theme_light() +
       theme(
-        legend.position = c(0.02, 0.98),
+        legend.position = c("inside"),
+        legend.position.inside = c(0.02, 0.98),
         legend.justification = c("left", "top"),
         legend.background = element_rect(fill = "transparent"),
         legend.title = if (!legend.title) element_blank(),

diff --git a/R/correlation.R b/R/correlation.R
@@ -89,7 +89,7 @@ pearsonTest <- function(x, y,
 #' interval(`lowerci` and `upperci`), Z statistic (`Z`) and p-value (`pval`)
 #' @export
 #'
-#' @seealso [cor.test()] [boot()] to see the detailed arguments.
+#' @seealso [cor.test()] [boot::boot()] to see the detailed arguments.
 #' @references NCSS correlation document
 #'
 #' @examples

diff --git a/cran-comments.md b/cran-comments.md
@@ -1,18 +1,7 @@
 ## Resubmission
 
-This is a resubmission. In this version I have:
-
-I have refreshed the `mcr` relevant functions as they were unavailable in last 
-version, and added a set of new features in current version.
+This is a resubmission, only few issues were updated.
 
 ## R CMD check results
 
-0 errors | 0 warnings | 1 note
-
-
-## revdepcheck results
-
-We checked 0 reverse dependencies, comparing R CMD check results across CRAN and dev versions of this package.
-
- * We saw 0 new problems
- * We failed to check 0 packages
+0 errors | 0 warnings | 0 note
diff --git a/man/VCAinference.Rd b/man/VCAinference.Rd
diff --git a/man/spearmanTest.Rd b/man/spearmanTest.Rd
diff --git a/mcradds.Rproj b/mcradds.Rproj
@@ -17,6 +17,6 @@ StripTrailingWhitespace: Yes
 
 BuildType: Package
 PackageUseDevtools: Yes
-PackagePath: C:/Users/TJ0695/Documents/mcradds
+PackagePath: C:/Users/TH0528/Documents/mcradds
 PackageInstallArgs: --no-multiarch --with-keep.source
 PackageRoxygenize: rd,namespace
diff --git a/tests/testthat/_snaps/autoplot/autoplot-basummary-with-relative-diff.svg b/tests/testthat/_snaps/autoplot/autoplot-basummary-with-relative-diff.svg
diff --git a/tests/testthat/_snaps/autoplot/autoplot-mcresult-with-default-arguments.svg b/tests/testthat/_snaps/autoplot/autoplot-mcresult-with-default-arguments.svg
diff --git a/tests/testthat/_snaps/autoplot/autoplot-mcresult-with-multiple-arguments.svg b/tests/testthat/_snaps/autoplot/autoplot-mcresult-with-multiple-arguments.svg