Bundle bios boot artifacts

[Itxaka]

This patch makes enki bundle the needed bios boot artifacts for livecd This uses embed to embed them in the final binary and not have to depend on anything external anymore.

This includes the core.img (which is grub+cdboot) and the boot_hybrid image. Plus the default livecd grub config file

This should result in enki being to be run as a simple binary without needing anything in the system (other than squashfs and xorriso to build the iso)

No artifacts from efi nor grub ones shold be needed anymore

[jimmykarily]

Does this mean they are also bundled in auroraboot when enki is imported as a library? Why not do this directly in Auroraboot since we are in the process of making it the "canonical" tool for building artifacts?

[Itxaka]

Does this mean they are also bundled in auroraboot when enki is imported as a library? Why not do this directly in Auroraboot since we are in the process of making it the "canonical" tool for building artifacts?

Mainly because that would meant moving the BuildISOAction fully and Im lazy :D
I did not want to do this work to then be blocked by something or the other. This is quick, 120 lines, no deps, no big changes, code-wise is like 20 lines tops so its easier to understand and I could wipe it out in 30 minutes and test it :D

[jimmykarily]

So both these lines can go away? https://github.com/kairos-io/osbuilder/blob/95509370f6a87229879f1a381afa5d47225ce12d/tools-image/Dockerfile#L28-L30

[Itxaka]

So both these lines can go away? kairos-io/osbuilder@9550937/tools-image/Dockerfile#L28-L30

ideally yes, they would go away

[Itxaka]

pixiecore uses git submodule + go-bindata which results in a static go file with methods to get the files code and such and it autogenerates them

Potentially we could do the same here by linking to the grub source and just building it on release, and bundling it with go-bindata, so it would be always in there (and I think its gzipped!) so its easier to track and bump any new artifacts.

[jimmykarily]

I ported these changes here: kairos-io/AuroraBoot#102
as part of archiving the enki repo (part of: kairos-io/kairos#1633)

I'll close this one.