This repository has been archived by the owner on Dec 16, 2024. It is now read-only.
Abstract a bit the uki commands #29
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make use of the config with the runners and vfs so we can easily tests the actions being taken and substitute those structs for others Signed-off-by: Itxaka <itxaka@kairos.io>
Itxaka
commented
Jan 23, 2024
| @@ -457,64 +456,25 @@ func copyFilesToImg(imgFile string, filesMap map[string][]string) error { | |||
| return nil | |||
| } | |||
|
|
|||
| func GzipFile(sourcePath, targetPath string) error { | |||
Itxaka
commented
Jan 23, 2024
| return nil | ||
| } | ||
|
|
||
| func findKairosVersion(sourceDir string) (string, error) { |
Itxaka
commented
Jan 23, 2024
| } | ||
| } | ||
| }) | ||
| It("Builds UKI Iso", func() {}) |
There was a problem hiding this comment.
Happening in this PR or other? Thanks for writing this btw, I looked at the other test and I was too afraid to try this :D.
There was a problem hiding this comment.
Hopefully in this one lmao
jimmykarily
approved these changes
Jan 25, 2024
|
Nice job! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make use of the config with the runners and vfs so we can easily tests the actions being taken and substitute those structs for others