Accept more paths to devices for install #552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Accepts any of the paths that udev adds for ease of use and are laying under /dev/disk/by-X As those are all softlinks to the actual device, it should be faily easy to just read the link and use the final target as that should always be a full device path (/dev/vda for example) Signed-off-by: Itxaka <itxaka@kairos.io>
Signed-off-by: Itxaka <itxaka@kairos.io>
Itxaka
force-pushed
the
accept_devices
branch
from
25da0cc
to
80f2e83
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #552 +/- ##
==========================================
- Coverage 49.80% 49.72% -0.08%
==========================================
Files 48 48
Lines 4566 4581 +15
==========================================
+ Hits 2274 2278 +4
- Misses 2018 2027 +9
- Partials 274 276 +2 ☔ View full report in Codecov by Sentry. |
Itxaka
commented
Sep 20, 2024
pkg/types/v1/config.go
Outdated
| @@ -76,6 +78,22 @@ type InstallSpec struct { | |||
| // Sanitize checks the consistency of the struct, returns error | |||
| // if unsolvable inconsistencies are found | |||
| func (i *InstallSpec) Sanitize() error { | |||
| // Accept that the target can be a /dev/disk/by-{label,uuid,path,etc..} and resolve it into a /dev/device | |||
There was a problem hiding this comment.
This would be moved into a method so It can be called from anywhere I guess.
mauromorales
approved these changes
Sep 20, 2024
Signed-off-by: Itxaka <itxaka@kairos.io>
Itxaka
force-pushed
the
accept_devices
branch
from
23d6f26
to
584bc88
Compare
Itxaka
force-pushed
the
accept_devices
branch
from
077034f
to
0819945
Compare
Itxaka
commented
Sep 20, 2024
| @@ -47,6 +47,27 @@ const ( | |||
| TiB | |||
| ) | |||
|
|
|||
| // TODO: Move it to the sdk | |||
| func resolveTarget(fs v1.FS, target string) (string, error) { | |||
There was a problem hiding this comment.
good here to test it directly on kairos via branches, if it works will move it into the sdk as its a very generic method that can be used everywhere, including immucore
jimmykarily
approved these changes
Sep 23, 2024
|
Trying to test it here: https://github.com/kairos-io/kairos/actions/runs/10990339501 |
renovate bot
referenced
this pull request
in kairos-io/provider-kairos
Sep 24, 2024
…4.2 (#639) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/kairos-io/kairos-agent/v2](https://redirect.github.com/kairos-io/kairos-agent) | `v2.14.1` -> `v2.14.2` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>kairos-io/kairos-agent (github.com/kairos-io/kairos-agent/v2)</summary> ### [`v2.14.2`](https://redirect.github.com/kairos-io/kairos-agent/releases/tag/v2.14.2) [Compare Source](https://redirect.github.com/kairos-io/kairos-agent/compare/v2.14.1...v2.14.2) #### What's Changed - chore(deps): update securego/gosec action to v2.21.3 by [@​renovate](https://redirect.github.com/renovate) in [https://github.com/kairos-io/kairos-agent/pull/547](https://redirect.github.com/kairos-io/kairos-agent/pull/547) - Revert "chore(deps): update securego/gosec action to v2.21.3" by [@​Itxaka](https://redirect.github.com/Itxaka) in [https://github.com/kairos-io/kairos-agent/pull/549](https://redirect.github.com/kairos-io/kairos-agent/pull/549) - chore(deps): update securego/gosec action to v2.21.3 by [@​renovate](https://redirect.github.com/renovate) in [https://github.com/kairos-io/kairos-agent/pull/551](https://redirect.github.com/kairos-io/kairos-agent/pull/551) - Expose the Analize method of yip by [@​Itxaka](https://redirect.github.com/Itxaka) in [https://github.com/kairos-io/kairos-agent/pull/548](https://redirect.github.com/kairos-io/kairos-agent/pull/548) - Revert "chore(deps): update securego/gosec action to v2.21.3" by [@​Itxaka](https://redirect.github.com/Itxaka) in [https://github.com/kairos-io/kairos-agent/pull/553](https://redirect.github.com/kairos-io/kairos-agent/pull/553) - fix(deps): update dependency codemirror to v5.65.18 by [@​renovate](https://redirect.github.com/renovate) in [https://github.com/kairos-io/kairos-agent/pull/555](https://redirect.github.com/kairos-io/kairos-agent/pull/555) - Accept more paths to devices for install by [@​Itxaka](https://redirect.github.com/Itxaka) in [https://github.com/kairos-io/kairos-agent/pull/552](https://redirect.github.com/kairos-io/kairos-agent/pull/552) **Full Changelog**: kairos-io/kairos-agent@v2.14.1...v2.14.2 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 11pm every weekday,before 7am every weekday,every weekend" in timezone Europe/Brussels, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/kairos-io/provider-kairos). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC44MC4wIiwidXBkYXRlZEluVmVyIjoiMzguODAuMCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Accepts any of the paths that udev adds for ease of use and are laying
under /dev/disk/by-X
As those are all softlinks to the actual device, it should be faily easy
to just read the link and use the final target as that should always be
a full device path (/dev/vda for example)
Fixes: kairos-io/kairos#1879
Signed-off-by: Itxaka itxaka@kairos.io