Fix mkfs using the wrong label for the fs label #556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were using the partion label as the fs label and the fs labe was nto used anywhere Signed-off-by: Itxaka <itxaka@kairos.io>
jimmykarily
approved these changes
Sep 24, 2024
mauromorales
approved these changes
Sep 24, 2024
Signed-off-by: Itxaka <itxaka@kairos.io>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #556 +/- ##
=======================================
Coverage 49.72% 49.72%
=======================================
Files 48 48
Lines 4581 4581
=======================================
Hits 2278 2278
Misses 2027 2027
Partials 276 276 ☔ View full report in Codecov by Sentry. |
renovate bot
referenced
this pull request
in kairos-io/provider-kairos
Sep 25, 2024
…4.4 (#640) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/kairos-io/kairos-agent/v2](https://redirect.github.com/kairos-io/kairos-agent) | `v2.14.2` -> `v2.14.4` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>kairos-io/kairos-agent (github.com/kairos-io/kairos-agent/v2)</summary> ### [`v2.14.4`](https://redirect.github.com/kairos-io/kairos-agent/releases/tag/v2.14.4) [Compare Source](https://redirect.github.com/kairos-io/kairos-agent/compare/v2.14.3...v2.14.4) #### What's Changed - Really resolve the link, not just get a relative link by [@​Itxaka](https://redirect.github.com/Itxaka) in [https://github.com/kairos-io/kairos-agent/pull/558](https://redirect.github.com/kairos-io/kairos-agent/pull/558) **Full Changelog**: kairos-io/kairos-agent@v2.14.3...v2.14.4 ### [`v2.14.3`](https://redirect.github.com/kairos-io/kairos-agent/releases/tag/v2.14.3) [Compare Source](https://redirect.github.com/kairos-io/kairos-agent/compare/v2.14.2...v2.14.3) #### What's Changed - Fix mkfs using the wrong label for the fs label by [@​Itxaka](https://redirect.github.com/Itxaka) in [https://github.com/kairos-io/kairos-agent/pull/556](https://redirect.github.com/kairos-io/kairos-agent/pull/556) **Full Changelog**: kairos-io/kairos-agent@v2.14.2...v2.14.3 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 11pm every weekday,before 7am every weekday,every weekend" in timezone Europe/Brussels, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/kairos-io/provider-kairos). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC44MC4wIiwidXBkYXRlZEluVmVyIjoiMzguODAuMCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were using the partion label as the fs label and the fs labe was nto used anywhere