Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add auto update command #557

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add auto update command #557

wants to merge 2 commits into from

Conversation

Itxaka
Copy link
Member

@Itxaka Itxaka commented Sep 24, 2024

Requested by @mauromorales :P

Signed-off-by: Itxaka <itxaka@kairos.io>
Copy link

codecov bot commented Sep 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.72%. Comparing base (ded356c) to head (20966e5).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #557   +/-   ##
=======================================
  Coverage   49.72%   49.72%           
=======================================
  Files          48       48           
  Lines        4581     4581           
=======================================
  Hits         2278     2278           
  Misses       2027     2027           
  Partials      276      276           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mauromorales
Copy link
Member

I guess the configuration would need a URL for the repository, no? And some versioning checks to know what's new and what's not?

@Itxaka
Copy link
Member Author

Itxaka commented Sep 24, 2024

I guess the configuration would need a URL for the repository, no? And some versioning checks to know what's new and what's not?

I thin it picks everything from the os-release file. the version and the original repo it was installed from so it would mostly work out of the box on existing installs. Not tested :P

Edit: yes it does. Same thing as the list-releases subcommand, it uses the existing data to get the list of releases from the remote repo. In this case, it just calls the upgrade afterwards :)

We dont fail out as if there is not newer releases we dont really care?

Signed-off-by: Itxaka <itxaka@kairos.io>
Copy link
Member

@mauromorales mauromorales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants