Try to get the flavor on EFI installs #568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If somehow our KAIROS_X keys are gone from the system due to something removing them like an upgrade, we wont be able to identify the flavors and we need it if its an ubuntu machine as we do a workaround for EFI installs, otherwise you get a broken grub. This tries to infer the flavor form the os-release ID field which will exist and check if its ubuntu. Signed-off-by: Itxaka <itxaka@kairos.io>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #568 +/- ##
==========================================
+ Coverage 49.80% 49.82% +0.02%
==========================================
Files 48 48
Lines 4582 4588 +6
==========================================
+ Hits 2282 2286 +4
- Misses 2026 2027 +1
- Partials 274 275 +1 ☔ View full report in Codecov by Sentry. |
mauromorales
approved these changes
Oct 1, 2024
42 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If somehow our KAIROS_X keys are gone from the system due to something removing them like an upgrade, we wont be able to identify the flavors and we need it if its an ubuntu machine as we do a workaround for EFI installs, otherwise you get a broken grub.
This tries to infer the flavor form the os-release ID field which will exist and check if its ubuntu.
Fixes: kairos-io/kairos#2895