Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the yip layout plugin #72

Merged
merged 6 commits into from
Jul 4, 2023
Merged

Use the yip layout plugin #72

merged 6 commits into from
Jul 4, 2023

Conversation

jimmykarily
Copy link
Contributor

@jimmykarily jimmykarily commented Jun 30, 2023

jimmykarily and others added 4 commits June 30, 2023 13:52
Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me>
to get this fix: mudler/yip#96

Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me>
Signed-off-by: Mauro Morales <mauro.morales@spectrocloud.com>
because that's what the yip plugin returns

Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me>
@codecov-commenter
Copy link

codecov-commenter commented Jun 30, 2023

Codecov Report

Merging #72 (8136810) into main (68e4bd6) will decrease coverage by 0.46%.
The diff coverage is 50.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main      #72      +/-   ##
==========================================
- Coverage   56.42%   55.96%   -0.46%     
==========================================
  Files          40       39       -1     
  Lines        4840     4774      -66     
==========================================
- Hits         2731     2672      -59     
+ Misses       1893     1889       -4     
+ Partials      216      213       -3     
Impacted Files Coverage Δ
pkg/partitioner/disk.go 56.06% <40.00%> (+0.14%) ⬆️
pkg/cloudinit/cloudinit.go 90.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@mauromorales mauromorales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mudler mudler requested review from Itxaka and removed request for Itxaka July 4, 2023 08:25
@mudler mudler assigned Itxaka and unassigned mauromorales and jimmykarily Jul 4, 2023
Brings fixes for layout plugin returning devices

Signed-off-by: Itxaka <itxaka.garcia@spectrocloud.com>
@Itxaka Itxaka merged commit e336c66 into main Jul 4, 2023
3 checks passed
@Itxaka Itxaka deleted the 1448-use-yip branch July 4, 2023 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants