Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write down the ordering of config read #270

Merged
merged 2 commits into from
Sep 26, 2024
Merged

Write down the ordering of config read #270

merged 2 commits into from
Sep 26, 2024

Conversation

Itxaka
Copy link
Member

@Itxaka Itxaka commented Sep 26, 2024

Signed-off-by: Itxaka <itxaka@kairos.io>
@Itxaka Itxaka requested a review from a team September 26, 2024 08:19
@Itxaka
Copy link
Member Author

Itxaka commented Sep 26, 2024

netlify hello?

Copy link

netlify bot commented Sep 26, 2024

Deploy Preview for kairos-io ready!

Name Link
🔨 Latest commit 85021d1
🔍 Latest deploy log https://app.netlify.com/sites/kairos-io/deploys/66f52e434fe6770008436a5e
😎 Deploy Preview https://deploy-preview-270--kairos-io.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@mauromorales mauromorales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm ... maybe worth mentioning that the user can do a kairos-agent config to check the final config or so?

Signed-off-by: Itxaka <itxaka@kairos.io>
Copy link
Contributor

@jimmykarily jimmykarily left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pending the removal of the /system/oem directory (as discussed here too: kairos-io/kairos-agent#550 (comment))

@Itxaka
Copy link
Member Author

Itxaka commented Sep 26, 2024

agent pr is merged so order can now be merged

@Itxaka Itxaka merged commit 1ba25c4 into main Sep 26, 2024
5 checks passed
@Itxaka Itxaka deleted the config_read_ordering branch September 26, 2024 13:17
@jimmykarily
Copy link
Contributor

Does this fix this too? kairos-io/kairos#2737

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants