Move to use kairos-release #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Itxaka <itxaka@kairos.io>
Signed-off-by: Itxaka <itxaka@kairos.io>
mauromorales
approved these changes
Oct 1, 2024
mudler
approved these changes
Oct 1, 2024
jimmykarily
reviewed
Oct 2, 2024
| sed -i -n '/KAIROS_/!p' /workspace/os-release | ||
| envsubst >>/workspace/os-release < /os-release.tmpl | ||
| envsubst >>/workspace/kairos-release < /kairos-release.tmpl |
There was a problem hiding this comment.
Don't we need the os-release fallback here too? What is this script used for? I can't find a consumer.
There was a problem hiding this comment.
our examples use it in the kairos repo. we should change those to use kairos-agent directly somehow and then we can deprecate this
Signed-off-by: Itxaka <itxaka@kairos.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of kairos-io/kairos#2907