Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add iso builder #70

Merged
merged 9 commits into from
Jul 20, 2023
Merged

Add iso builder #70

merged 9 commits into from
Jul 20, 2023

Conversation

Itxaka
Copy link
Member

@Itxaka Itxaka commented Jul 18, 2023

This adds a new package for the iso builder run directly on go. This is extracted from the original elemental-cli and then from the now build-less kairos-agent

This uses no deps on elemental, only deps are on kairos-agent for the config stuff mainly.

Part of kairos-io/kairos#711

I have already build an iso with this and seems to work. Command should be a drop-in replacement of elemental-cli for building isos.

The main difference is dropping uneeded stuff (like bootloader-in-rootfs), convergin the constants in one place, dropping the liveiso stuff as we dont need that at all and disabling squashfs compression by default

Also updates the dockerfile to be simpler, install everything from the repository directly

This adds a new package for the iso builder run directly on go.
This is extracted from the original elemental-cli and then from the now
build-less kairos-agent

This uses no deps on elemental, only deps are on kairos-agent for the
config stuff mainly.

Signed-off-by: Itxaka <itxaka.garcia@spectrocloud.com>
@Itxaka Itxaka requested a review from a team July 18, 2023 10:51
Install all packages via luet, converges the rpi packages into one,
makes arm use the same generic packages as x86 as they now come from the
proper architecture and reduces dockerfile complexity

Signed-off-by: Itxaka <itxaka.garcia@spectrocloud.com>
@Itxaka Itxaka force-pushed the osbuilder_go branch 2 times, most recently from 828905c to dc79429 Compare July 18, 2023 13:15
Signed-off-by: Itxaka <itxaka.garcia@spectrocloud.com>
@Itxaka
Copy link
Member Author

Itxaka commented Jul 18, 2023

Seems to work, this branch is using a new osbuilder pushed with this branch changes and everything was build correctrly:

kairos-io/kairos#1615

@Itxaka Itxaka requested a review from a team July 19, 2023 08:20
Signed-off-by: Itxaka <itxaka.garcia@spectrocloud.com>
Signed-off-by: Itxaka <itxaka.garcia@spectrocloud.com>
Signed-off-by: Itxaka <itxaka.garcia@spectrocloud.com>
Signed-off-by: Itxaka <itxaka.garcia@spectrocloud.com>
@Itxaka
Copy link
Member Author

Itxaka commented Jul 19, 2023

Tested again with the latest changes, still working

Copy link
Member

@mauromorales mauromorales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Signed-off-by: Itxaka <itxaka.garcia@spectrocloud.com>
@Itxaka Itxaka merged commit ce8fe1f into kairos-io:master Jul 20, 2023
6 of 8 checks passed
@Itxaka Itxaka deleted the osbuilder_go branch July 20, 2023 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants