Add Nim to TranslatorSpec and fix various errors found thanks to that #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mingun
changed the title
Octal escape sequences the least used form of escape sequences and hex supported everywhere. The only outsiders are Java, C++ and Rust
BaseTranslator does not insert space between operator and expression. When expression is a number, "~<number>" and "!<number>" becomes "not<number>" which is an identifier Fixes test (1): ``` [info] - nim:~777 *** FAILED *** [info] "not[]777" was not equal to "not[ ]777" (TranslatorSpec.scala:183) [info] Analysis: [info] "not[]777" -> "not[ ]777" ```
Integer division operator is `div` Float division operator is `/`
…, .to_i and substring methods
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes #291, because Nim octal escapes will consume all possible digits, so string with escape sequence followed by digit will be treated incorrectly. Hex escape form does not suffer from such problem. Instead of overriding logic in Nim I decided to make a Hex representation as default because most languages have it. If you do not agree, please tell me and I change that.
This PR fixes the following bugs found during testing:
notkeyword and require a space after it, so~777not become identifiernot777. Lua was suffer from the same problem.if ...: ... else: ...expression), casts and string concatenation (&operator)divand/accordingly. Attempt to usedivwith float numbers lead to a compilation error. This was fixed in the same way as Python does that by inspecting deduced types of an arguments.first,.last,.to_i,.substringmethods called on expressions does not wrap them into parenthesis, so(1 + 2).to_ibecomes1 + 2.to_iI checked all generated expressions on https://play.nim-lang.org/ so I assume that their all are correct.
I also notice a strange thing. Nim has an extendable
$operator to converting everything to a string. However,.to_simplementation generatesintToStr(int(value))which means conversion to integer, then conversion to string. It seems that it is possible to replace that stuff with$operator stuff, but maybe there are some nuances. @sealmove, you a created Nim implementation, can you check, is that possible?