C#: slightly tweak KST generator to generate more automatic tests #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mingun
commented
Apr 6, 2024
translator/src/main/scala/io/kaitai/struct/testtranslator/specgenerators/CSharpSG.scala
Outdated
Show resolved
Hide resolved
Mingun
force-pushed
the
cs-kst-fixes
branch
from
d311a80 to
7e96705
Compare
Tests regenerated using this command: ./spec_kst_to_all -t csharp --all-specs -f
…ted by Assert class
Mingun
force-pushed
the
cs-kst-fixes
branch
from
7e96705 to
5aa45d8
Compare
|
@generalmimon, is there something wrong with this PR? If yes, could you tell me what? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR generates casts of numerical expected values to enumerations if the actual value of the enum type.
This PR depends on kaitai-io/kaitai_struct_compiler#296 and should be merged only after it.