Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor updates to PR #76

Merged
merged 1 commit into from
Oct 21, 2024
Merged

Conversation

kbonney
Copy link

@kbonney kbonney commented Oct 15, 2024

Summary

  • Removed mutable default argument in _extract_dataframe.
  • Fixed a few places in the docs where truncate was used instead of truncate_names for the valid_gis_names argument.
  • Clarified the use of complete_list in the user guide and docstring for valid_gis_names.

Tests and documentation

Acknowledgement

By contributing to this software project, I acknowledge that I have reviewed the software quality assurance guidelines and that my contributions are submitted under the Revised BSD License.

@kbonney
Copy link
Author

kbonney commented Oct 15, 2024

Not sure why tests are failing. I am seeing the failures ocurring in test_graphics, which shouldn't have anything to do with these changes.

@kaklise kaklise merged commit 57880bf into kaklise:valid_gis_names Oct 21, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants