Fixed Container would not draw children when draw was called #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 125b4aa.
If we had a container with child objects, they would not be updated/drawn when the container's "draw" function was called.
Jarod42
reviewed
Nov 9, 2024
- Use for range loop - Fix warnings about type mismatch (int vs unsigned int)
This reverts commit 468fc20.
Jarod42
approved these changes
Nov 10, 2024
midwan
added a commit
to midwan/guisan
that referenced
this pull request
Nov 13, 2024
commit 85989b7 Author: Jarod42 <Jarod42@users.noreply.github.com> Date: Mon Nov 11 10:07:54 2024 +0100 [cleanup] Fix some MSVC warnings - C4127 conditional expression is constant - C4189 '%var': local variable is initialized but not referenced commit e0a581b Author: Dimitris Panokostas <midwan@gmail.com> Date: Sun Nov 10 17:49:04 2024 +0100 Fixed Container would not draw children when draw was called (kallisti5#125) * Use const in more places * Revert "Use const in more places" This reverts commit 125b4aa. * Fixed container would not draw child objects when draw was called on it If we had a container with child objects, they would not be updated/drawn when the container's "draw" function was called. * Use for range loop, fix compiler warnings - Use for range loop - Fix warnings about type mismatch (int vs unsigned int) * Use =0 for new functions, use default for destructor * Revert "Use =0 for new functions, use default for destructor" This reverts commit 468fc20.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we create a Container widget, and add some items to it (like an icon and a label in my example case), they never get drawn when the container's "draw" function is called.
To fix this, I'm adding a
drawChildrenfunction that will iterate through any child widgets and trigger the draw function on them.Not sure if there's a better way around this, but this worked for me. :)