Add PasswordField widget #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jarod42
reviewed
Nov 14, 2024
Co-authored-by: Joris Dauphin <Jarod42@users.noreply.github.com>
midwan
approved these changes
Nov 15, 2024
Jarod42
reviewed
Nov 15, 2024
| * | ||
| * @param mask the masking character | ||
| */ | ||
| void setMaskingChar(const char mask); |
There was a problem hiding this comment.
getter might be useful too.
Co-authored-by: Joris Dauphin <Jarod42@users.noreply.github.com>
Jarod42
approved these changes
Nov 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So, this is an old (8 years old) addition I made to my fork of guisan and for some reason, never contributed back to the main repo. Basically, it is just a text field but with hidden text, which is suitable for - you guessed it - passwords.
I quickly updated it a few days ago to adjust to the upstream changes, but it may need some more improvements before merging. In particular, it may be good to make the masking character configurable through a setter.