Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply guichan's change 8565f3e8ce86c771551dadc2d91cf883d7f9d917 (dec 22th 2007) #26

Merged
merged 1 commit into from
Jul 9, 2024

Conversation

Jarod42
Copy link
Collaborator

@Jarod42 Jarod42 commented Dec 1, 2023

  • Documentation has been enhanced.
  • The alignment enum in Graphics, the orientation enum in Slider and the scroll policy enum in ScrollArea are no longer anonymous enums.
  • Locale variable names have in some places been changed to better reflect their purpose.
  • move some methods from public to protected.

…22th 2007)

- Documentation has been enhanced.
- The alignment `enum` in `Graphics`, the orientation `enum` in `Slider` and the scroll policy `enum` in `ScrollArea` are no longer anonymous enums.
- Locale variable names have in some places been changed to better reflect their purpose.
- move some methods from `public` to `protected`.
@kallisti5
Copy link
Owner

@Jarod42 I'm inviting you as a collaborator to this repository. I've fell behind maintaining it, and it looks like a few people want to work on it as of Dec 2023. The outstanding patches are large enough, I don't have the bandwidth to review all of them.

@kallisti5
Copy link
Owner

@midwan FYI about the above. I'll rope you in as a collaborator as well. My only ask is to do a bit of code review of each other since y'all have some long pull requests outstanding :-)

@midwan
Copy link
Collaborator

midwan commented Jun 24, 2024

@kallisti5
Thanks!
I was planning on coming back to my PR, now that the summer break is closing in. So I think I'll split it up as suggested and re-submit it in a more clean way. :)

@kallisti5
Copy link
Owner

Yup! Sorry for letting these sit for so long. It's been a busy year, and my project time has been shorter than usual.

@Jarod42
Copy link
Collaborator Author

Jarod42 commented Jul 3, 2024

Just waiting for review (to do or to receive ;-) )

Copy link
Collaborator

@midwan midwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@Jarod42 Jarod42 merged commit 352047b into kallisti5:master Jul 9, 2024
1 check passed
@Jarod42 Jarod42 deleted the doc_enum branch July 9, 2024 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants