-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] - Feature train orb #31
base: dev
Are you sure you want to change the base?
Changes from 1 commit
1ed5e9b
16ef354
7b4c753
4947a36
84f244e
4a98c9d
fa99cb0
6cb26db
c3cb621
63b379c
dc0f0bd
bc246fb
f7d062f
5d75388
8094ba6
220a528
6fe0b12
1b0ff8b
b5afa69
549e18a
a7f311f
4a0cf97
283c22e
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -151,14 +151,15 @@ void train_orb_pattern_internal(const char* filename) { | |
} | ||
webarkitLOGi("Image done!"); | ||
|
||
JSLOGi("Starting detection routine..."); | ||
JSLOGi("Starting detection routine...\n"); | ||
|
||
Orb orb; | ||
Imgproc imgproc; | ||
detectors::Detectors detectors; | ||
std::unique_ptr<Matrix_t> lev0_img = std::make_unique<Matrix_t>(jpegImage->xsize, jpegImage->ysize, ComboTypes::U8C1_t); | ||
std::unique_ptr<Matrix_t> lev_img = std::make_unique<Matrix_t>(jpegImage->xsize, jpegImage->ysize, ComboTypes::U8C1_t); | ||
Array<std::unique_ptr<Matrix_t>> pattern_corners; | ||
std::cout << "after orb" << std::endl; | ||
|
||
auto sc0 = std::min(max_pattern_size / jpegImage->ysize, max_pattern_size / jpegImage->xsize); | ||
new_width = (jpegImage->ysize * sc0) | 0; | ||
|
@@ -168,14 +169,17 @@ void train_orb_pattern_internal(const char* filename) { | |
auto i_u8_size = jpegImage->xsize * jpegImage->ysize * jpegImage->nc; | ||
Array<u_char> i_u8(jpegImage->image, jpegImage->image + i_u8_size); | ||
std::unique_ptr<Matrix_t> img_u8 = std::make_unique<Matrix_t>(jpegImage->xsize, jpegImage->ysize, ComboTypes::U8C4_t, i_u8); | ||
|
||
imgproc.resample(img_u8.get(), lev0_img.get(), new_width, new_height); | ||
|
||
|
||
JSLOGi("Resampling image..."); | ||
|
||
//imgproc.resample(img_u8.get(), lev0_img.get(), new_width, new_height); | ||
|
||
JSLOGi("Image resampled, starting pyramid now..."); | ||
// prepare preview | ||
std::unique_ptr<Matrix_t> pattern_preview = std::make_unique<Matrix_t>(jpegImage->xsize >> 1, jpegImage->ysize >> 1, ComboTypes::U8C1_t); | ||
imgproc.pyrdown_internal(lev0_img.get(), pattern_preview.get()); | ||
|
||
Array<KeyPoints> lev_corners; | ||
Array<KeyPoints*> lev_corners(4); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. i think we should provide a array of pointers and pre init them. |
||
Array<std::unique_ptr<Matrix_t>> pattern_descriptors; | ||
|
||
for (lev = 0; lev < num_train_levels; ++lev) { | ||
|
@@ -186,22 +190,30 @@ void train_orb_pattern_internal(const char* filename) { | |
// preallocate corners array | ||
i = (new_width * new_height) >> lev; | ||
while (--i >= 0) { | ||
lev_corners[lev].set_size(i); | ||
lev_corners[lev]->set_size(i); | ||
lev_corners[lev]->allocate(); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. we need to set the size and allocate the entire set. |
||
} | ||
std::cout << "Num. of level: " << lev << std::endl; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this print 4 levels in the console: |
||
pattern_descriptors.push_back(std::unique_ptr<Matrix_t>(new Matrix_t(32, max_per_level, ComboTypes::U8C1_t))); | ||
} | ||
|
||
imgproc.gaussian_blur_internal(lev0_img.get(), lev_img.get(), 5, 0.2); // this is more robust | ||
//std::cout << "Size of first lev_corners: " << lev_corners[0]->kpoints.size() << std::endl; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is not printed... |
||
|
||
imgproc.gaussian_blur_internal(lev0_img.get(), lev_img.get(), 5, 2); // this is more robust | ||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is ok , it is printed... |
||
JSLOGi("After Gaussian blur"); | ||
|
||
corners_num = detectors.detect_keypoints(lev_img.get(), lev_corners[0], max_per_level); | ||
|
||
// orb.describe(lev_img.get(), lev_corners[0], corners_num, lev_descr.get()); | ||
// This probablly will work in a near future | ||
// orb.describe(lev_img.get(), lev_corners[0], corners_num, &pattern_descriptors[0]); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. orb.describe can not be yet used here because it accept in the first parameter a |
||
|
||
// console.log("train " + lev_img.cols + "x" + lev_img.rows + " points: " + corners_num); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ...continuning from below, These two printings instead do nothing. I will open an issue as reminder. |
||
JSLOGi("Corners num: %i", corners_num); | ||
JSLOGi("train %i x %i points: %i\n", lev_img.get()->get_cols(), lev_img.get()->get_rows(), corners_num); | ||
std::cout << "train " << lev_img.get()->get_cols() << " x " << lev_img.get()->get_rows() << " points: " << corners_num << std::endl; | ||
std::cout << "Corners num: " << (int)corners_num << std::endl; | ||
//JSLOGi("Corners num: %i", corners_num); | ||
//JSLOGi("train %i x %i points: %i\n", lev_img.get()->get_cols(), lev_img.get()->get_rows(), corners_num); | ||
//std::cout << "train " << lev_img.get()->get_cols() << " x " << lev_img.get()->get_rows() << " points: " << corners_num << std::endl; | ||
free(ext); | ||
free(jpegImage); | ||
}; | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -18,22 +18,26 @@ class Detectors : public Yape06, public Math, public KeyPointsFilter { | |
Detectors() {} | ||
~Detectors() {} | ||
|
||
int detect_keypoints(Matrix_t* img, KeyPoints corners, int max_allowed) { | ||
int detect_keypoints(Matrix_t* img, KeyPoints* corners, int max_allowed) { | ||
// detect features | ||
auto kpc = detect_internal(img, &corners, 17); | ||
auto kpc = detect_internal(img, corners, 17); | ||
auto count = kpc.count; | ||
std::cout << "here" << std::endl; | ||
//std::cout << count << std::endl; | ||
// sort by score and reduce the count if needed | ||
if (count > max_allowed) { | ||
// qsort_internal<KeyPoint_t, bool>(corners.kpoints, 0, count - 1, [](KeyPoint_t i, KeyPoint_t j){return (i.score < j.score);}); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm not sure of this, maybe it's better to use another small different approach. I'm looking to the OpenCV code in the Orb implementation and there is another possibility. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. retainBest is taken from OpenCV, but i need to figure out if this is correct. |
||
retainBest(corners.kpoints, count); | ||
retainBest(corners->kpoints, count); | ||
count = max_allowed; | ||
} | ||
|
||
// calculate dominant orientation for each keypoint | ||
for (auto i = 0; i < count; ++i) { | ||
corners.kpoints[i].angle = ic_angle(img, corners.kpoints[i].x, corners.kpoints[i].y); | ||
corners->kpoints[i].angle = ic_angle(img, corners->kpoints[i].x, corners->kpoints[i].y); | ||
} | ||
|
||
//std::cout << count << std::endl; | ||
|
||
return count; | ||
} | ||
|
||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -35,6 +35,12 @@ class KeyPoints { | |
this->size = kp.size; | ||
this->kpoints = kp.kpoints; | ||
} | ||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I added tha allocate function because if you initialize a KeyPoints with the default constructor it will not init the |
||
auto allocate() { | ||
KeyPoint_t kpt(0, 0, 0, 0, -1); | ||
kpoints.assign(this->size, kpt); | ||
} | ||
|
||
auto get_size() const {return size; }; | ||
|
||
auto set_size(int size) { this->size = size; }; | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -84,6 +84,7 @@ class Yape06 { | |
} | ||
} | ||
} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this not printing anything... There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. now it display some value: |
||
std::cout << "count: " << ypts.count << std::endl; | ||
|
||
return ypts; | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resampling is not needed in our case, because we provide our image with the right size. The code was taken by the jsfeat sample_orb example and in that case we simply resampled the image taken by the canvas(webcam) to a smaller size. Anyway the resample function has some issues, infact the log console "Image resampled, starting pyrmaid now..." can not be printed with this function enabled. (just comment out and recompile to test)