Simplify imgproc class. #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I fixed the |
kalwalt
commented
Nov 25, 2022
| @@ -268,10 +268,10 @@ class Imgproc : public Math { | |||
|
|
|||
| dst->resize(w2, h2, src->get_channel_m()); | |||
|
|
|||
There was a problem hiding this comment.
It seems strange to me that this can not copy the data, i will fill an issue for this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As stated in this comment i will try to simplify and improve the imgproc class. At this time the methods aretoo Emscripten orientedin the sense they are specifically designed to be compiled directly with EMscripten, but if you want to use them internally with C++ code (and then after compiled with Emscripten) it can be hard or worste ca scenario near impossible. I will try to simplify the grayscale's methods and then if i can others. This is a necessary step for PR #31.
List of changes:
ifelsefor Emscripten grayscale, instead add if define only for the Emscripten version.