Plug memory leak in StringMarshaller (#13)

kant2002 · Jul 11, 2021 · 36a22d2 · 36a22d2
1 parent 5d998fd
commit 36a22d2
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/WinFormsComInterop.SourceGenerator.Tests/RuntimeCallableWrapperTest.cs b/WinFormsComInterop.SourceGenerator.Tests/RuntimeCallableWrapperTest.cs
@@ -1105,6 +1105,7 @@ unsafe partial class C : global::Foo.IStr
  Marshal.ThrowExceptionForHR(result);
  }
 
+ Marshal.FreeCoTaskMem(local_1);
  }
  finally
  {

diff --git a/WinFormsComInterop.SourceGenerator/StringMarshaller.cs b/WinFormsComInterop.SourceGenerator/StringMarshaller.cs
@@ -59,6 +59,11 @@ public override void UnmarshalParameter(IndentedStringBuilder builder)
  {
  builder.AppendLine($"{Name} = Marshal.PtrToStringUni({LocalVariable});");
  }
+
+ if (RefKind != RefKind.Out && Index != -1)
+ {
+ builder.AppendLine($"Marshal.FreeCoTaskMem({LocalVariable});");
+ }
  }
  }
 }