-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support ppc64le and riscv64 #5
Conversation
Add `BASE_MAGIC_ID` in ppc64le and riscv64 archs. Signed-off-by: Yadong Ding <ding_yadong@foxmail.com>
Maybe we need also to add the test jobs for powerpc64 and riscv64 in github action. |
Add test in |
Add test in amd64, arm64, ppc64le, riscv64. Signed-off-by: Yadong Ding <ding_yadong@foxmail.com>
495305a
to
5d75df9
Compare
PTAL @bergwolf, Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'd better contribute it to https://github.com/firecracker-microvm/firecracker/tree/main/src/snapshot as well, but it seems that firecracker doesn't support ppc64le and riscv64 yet.
I will try it, maybe the maintainers of https://github.com/firecracker-microvm/firecracker have some other considerations. |
I have contributed it to https://github.com/firecracker-microvm/firecracker in firecracker-microvm#4319. Can we merge this and release it first? Because firecracker doesn't support |
See firecracker-microvm#4319 (comment), we can only use this in our fork crate. |
@bergwolf It seems the CI hang on "Waiting for status to be reported", is the setting correct? |
/test |
Ref: dragonflyoss/nydus#1510.
Add
BASE_MAGIC_ID
in ppc64le and riscv64 archs.