Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support reStructuredText #60

Merged

Conversation

MichaHoffmann
Copy link
Contributor

This PR adds support for terraform manifests that are embedded in reStructuredText files.

@MichaHoffmann
Copy link
Contributor Author

I tested this on a bunch of .rst files. It looked good, not sure if this is the best approach though. Please consider this as just a suggestion.

@dewan-ahmed
Copy link

Hi @katbyte could you pls check out this PR and see if .RST can be supported? Thanks.

Copy link
Owner

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pr @MichaHoffmann! - overall looks good and i like the methold! most my comments are fairly minor and should be easy to address.

Sadly i get to many notifications in gh for me to catch most things so please feel free to join the azurerm community slack mentioned in the azurerm readme and DM me directly about this PR once it's ready (or fire me off an email)

look forward to getting this in 🙂

lib/blocks/blockreader.go Outdated Show resolved Hide resolved
lib/blocks/blockreader.go Outdated Show resolved Hide resolved
lib/blocks/blockreader.go Outdated Show resolved Hide resolved
lib/blocks/blockreader_test.go Outdated Show resolved Hide resolved
lib/blocks/blockreader.go Outdated Show resolved Hide resolved
lib/blocks/blockreader.go Outdated Show resolved Hide resolved
lib/blocks/testdata/test3.rst Show resolved Hide resolved
cli/cmds.go Outdated Show resolved Hide resolved
@katbyte katbyte added this to the v0.5.0 milestone Aug 3, 2022
@MichaHoffmann MichaHoffmann force-pushed the mhoffm-add-restructured-text-support branch 5 times, most recently from 8474ab6 to 731cc15 Compare August 7, 2022 13:16
@MichaHoffmann MichaHoffmann requested a review from katbyte August 7, 2022 13:16
@MichaHoffmann MichaHoffmann force-pushed the mhoffm-add-restructured-text-support branch from 731cc15 to 0028921 Compare August 7, 2022 13:22
Copy link
Owner

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @MichaHoffmann - LGTM now 🌵 , few linting errors to fix but good to merge once they have been addressed

@MichaHoffmann MichaHoffmann force-pushed the mhoffm-add-restructured-text-support branch from 0028921 to 7dd1200 Compare August 8, 2022 17:54
@mhoffm-aiven
Copy link

Linter failures seem unrelated

@MichaHoffmann MichaHoffmann force-pushed the mhoffm-add-restructured-text-support branch from 7dd1200 to 05a0ec9 Compare August 9, 2022 04:58
@katbyte katbyte merged commit d803c2a into katbyte:main Aug 9, 2022
katbyte added a commit that referenced this pull request Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants