-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support reStructuredText #60
feat: support reStructuredText #60
Conversation
I tested this on a bunch of .rst files. It looked good, not sure if this is the best approach though. Please consider this as just a suggestion. |
f471db9
to
9fdb760
Compare
Hi @katbyte could you pls check out this PR and see if .RST can be supported? Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the pr @MichaHoffmann! - overall looks good and i like the methold! most my comments are fairly minor and should be easy to address.
Sadly i get to many notifications in gh for me to catch most things so please feel free to join the azurerm community slack mentioned in the azurerm readme and DM me directly about this PR once it's ready (or fire me off an email)
look forward to getting this in 🙂
8474ab6
to
731cc15
Compare
731cc15
to
0028921
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @MichaHoffmann - LGTM now 🌵 , few linting errors to fix but good to merge once they have been addressed
0028921
to
7dd1200
Compare
Linter failures seem unrelated |
7dd1200
to
05a0ec9
Compare
This PR adds support for terraform manifests that are embedded in reStructuredText files.