Merge remote-tracking branch 'origin/lb/repro-ci-images' into lb/repr…

…o-ci-images
kavigupta · Sep 17, 2024 · 5ef2e84 · 5ef2e84
2 parents 1842300 + feed7f4
commit 5ef2e84
Showing 1 changed file with 2 additions and 0 deletions.
diff --git a/.github/workflows/check.yml b/.github/workflows/check.yml
@@ -108,6 +108,7 @@ jobs:
   check-screenshots:
     runs-on: ubuntu-22.04
     needs: [build-and-push-image, list-e2e-tests, run-e2e-tests]
+    if: ${{ !cancelled() && needs.build-and-push-image.result == 'success' && needs.list-e2e-tests.result == 'success' }} # Should run even if e2e tests fail
     container:
       image: ghcr.io/${{ needs.build-and-push-image.outputs.image_tag }}
     strategy:
@@ -142,6 +143,7 @@ jobs:
         with:
           name: delta
           pattern: "delta-*"
+        continue-on-error: true
       - uses: actions/upload-artifact/merge@v4
         with:
           name: combined