refactor: searchUserCell

kawamataryo · Jan 5, 2025 · dacfc41 · dacfc41
1 parent 3be16f4
commit dacfc41
Show file tree

Hide file tree

Showing 5 changed files with 21 additions and 48 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/src/lib/domHelpers.ts b/src/lib/domHelpers.ts
@@ -28,3 +28,18 @@ export const scrapeListNameFromPage = (): string => {
   }
   return "Imported List from X";
 };
+
+export const searchUserCells = (userCell: HTMLElement): HTMLElement[] => {
+  if (!userCell) {
+    return [];
+  }
+  const cellTextCount = (userCell.innerText ?? "").split("\n").length;
+  const hasAvatar = !!userCell.querySelector("img");
+  if (1 <= cellTextCount && cellTextCount <= 3 && hasAvatar) {
+    return [userCell];
+  }
+  if (userCell.children.length === 0) {
+    return [];
+  }
+  return Array.from(userCell.children).flatMap(searchUserCells);
+};
diff --git a/src/lib/services/instagramService.ts b/src/lib/services/instagramService.ts
@@ -1,23 +1,9 @@
+import { searchUserCells } from "~lib/domHelpers";
 import { findFirstScrollableElements } from "~lib/utils";
 import type { CrawledUserInfo, IService, MessageName } from "~types";
 
 const SCROLL_TARGET_SELECTOR = '[role="dialog"]';
 
-const searchUserCells = (userCell: HTMLElement): HTMLElement[] => {
-  if (!userCell) {
-    return [];
-  }
-  const cellTextCount = (userCell.innerText ?? "").split("\n").length;
-  const hasAvatar = !!userCell.querySelector("img");
-  if (1 <= cellTextCount && cellTextCount <= 3 && hasAvatar) {
-    return [userCell];
-  }
-  if (userCell.children.length === 0) {
-    return [];
-  }
-  return Array.from(userCell.children).flatMap(searchUserCells);
-};
-
 export class InstagramService implements IService {
   messageName: MessageName;
   crawledUserCells: Set<HTMLElement>;

diff --git a/src/lib/services/threadsService.ts b/src/lib/services/threadsService.ts
@@ -1,24 +1,10 @@
+import { searchUserCells } from "~lib/domHelpers";
 import { findFirstScrollableElements } from "~lib/utils";
 import type { CrawledUserInfo, IService, MessageName } from "~types";
 
 const TARGET_PAGE_SELECTOR = '[role="dialog"] [role="tab"]>[role="button"]';
 const SCROLL_TARGET_SELECTOR = '[role="dialog"]';
 
-const searchUserCells = (userCell: HTMLElement): HTMLElement[] => {
-  if (!userCell) {
-    return [];
-  }
-  const cellTextCount = (userCell.innerText ?? "").split("\n").length;
-  const hasAvatar = !!userCell.querySelector("img");
-  if (1 <= cellTextCount && cellTextCount <= 3 && hasAvatar) {
-    return [userCell];
-  }
-  if (userCell.children.length === 0) {
-    return [];
-  }
-  return Array.from(userCell.children).flatMap(searchUserCells);
-};
-
 export class ThreadsService implements IService {
   messageName: MessageName;
   crawledUserCells: Set<HTMLElement>;

diff --git a/src/lib/services/tikTokService.ts b/src/lib/services/tikTokService.ts
@@ -1,23 +1,9 @@
+import { searchUserCells } from "~lib/domHelpers";
 import { findFirstScrollableElements } from "~lib/utils";
 import type { CrawledUserInfo, IService, MessageName } from "~types";
 
 const SCROLL_TARGET_SELECTOR = '[data-e2e="follow-info-popup"]';
 
-const searchUserCells = (userCell: HTMLElement): HTMLElement[] => {
-  if (!userCell) {
-    return [];
-  }
-  const cellTextCount = (userCell.innerText ?? "").split("\n").length;
-  const hasAvatar = !!userCell.querySelector("img");
-  if (1 <= cellTextCount && cellTextCount <= 3 && hasAvatar) {
-    return [userCell];
-  }
-  if (userCell.children.length === 0) {
-    return [];
-  }
-  return Array.from(userCell.children).flatMap(searchUserCells);
-};
-
 export class TikTokService implements IService {
   messageName: MessageName;
   crawledUserCells: Set<HTMLElement>;
@@ -72,7 +58,7 @@ export class TikTokService implements IService {
       displayName,
       accountNameRemoveUnderscore,
       accountNameReplaceUnderscore,
-      bskyHandle: "",
+      bskyHandleInDescription: "",
       originalAvatar: avatarSrc,
       originalProfileLink: `https://www.tiktok.com/@${_accountName}`,
     };