Update initial position sampling in maximize_likelihood #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasckng
changed the base branch from
jim-dev
to
150-slow-initialize-point-generation
|
@kazewong Other parts of this function require changes as well. I am not sure how to do that, do you mind taking a look later? |
|
I am not sure what you are trying to do here. The original PR has already been merged. |
|
The function I changed is in |
thomasckng
changed the base branch from
150-slow-initialize-point-generation
to
jim-dev
|
The loops before and after the code I modified still need some work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the same code in #152 for
maximize_likelihood.