Fix #97 - make Sql Server configuration properties public #241
Annotations
10 warnings
Build:
src/KernelMemory.MemoryStorage.SqlServer/SqlServerMemory.cs#L595
Missing XML comment for publicly visible type or member 'SqlServerMemory.Dispose()'
|
Build:
src/KernelMemory.MemoryStorage.SqlServer/SqlServerMemory.cs#L26
Provide an overridable implementation of Dispose(bool) on 'SqlServerMemory' or mark the type as sealed. A call to Dispose(false) should only clean up native resources. A call to Dispose(true) should clean up both managed and native resources. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1063)
|
Build:
src/KernelMemory.MemoryStorage.SqlServer/KernelMemoryBuilderExtensions.cs#L19
In externally visible method 'IKernelMemoryBuilder KernelMemoryBuilderExtensions.WithSqlServerMemoryDb(IKernelMemoryBuilder builder, SqlServerConfig config)', validate parameter 'builder' is non-null before using it. If appropriate, throw an 'ArgumentNullException' when the argument is 'null'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1062)
|
Build:
src/KernelMemory.MemoryStorage.SqlServer/KernelMemoryBuilderExtensions.cs#L30
In externally visible method 'IKernelMemoryBuilder KernelMemoryBuilderExtensions.WithSqlServerMemoryDb(IKernelMemoryBuilder builder, string connString)', validate parameter 'builder' is non-null before using it. If appropriate, throw an 'ArgumentNullException' when the argument is 'null'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1062)
|
Build:
src/KernelMemory.MemoryStorage.SqlServer/SqlServerMemory.cs#L154
In externally visible method 'Task SqlServerMemory.DeleteAsync(string index, MemoryRecord record, CancellationToken cancellationToken = default(CancellationToken))', validate parameter 'record' is non-null before using it. If appropriate, throw an 'ArgumentNullException' when the argument is 'null'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1062)
|
Build:
src/KernelMemory.MemoryStorage.SqlServer/SqlServerMemory.cs#L413
In externally visible method 'Task<string> SqlServerMemory.UpsertAsync(string index, MemoryRecord record, CancellationToken cancellationToken = default(CancellationToken))', validate parameter 'record' is non-null before using it. If appropriate, throw an 'ArgumentNullException' when the argument is 'null'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1062)
|
Build:
src/KernelMemory.MemoryStorage.SqlServer/SqlServerMemory.cs#L589
In method 'NormalizeIndexName', replace the call to 'ToLowerInvariant' with 'ToUpperInvariant' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1308)
|
Build:
src/KernelMemory.MemoryStorage.SqlServer/SqlServerMemory.cs#L595
Modify 'SqlServerMemory.Dispose' so that it calls Dispose(true), then calls GC.SuppressFinalize on the current object instance ('this' or 'Me' in Visual Basic), and then returns (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1063)
|
Build:
src/KernelMemory.MemoryStorage.SqlServer/SqlServerMemory.cs#L595
Change SqlServerMemory.Dispose() to call GC.SuppressFinalize(object). This will prevent derived types that introduce a finalizer from needing to re-implement 'IDisposable' to call it. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1816)
|
Build:
src/KernelMemory.MemoryStorage.SqlServer/SqlServerMemory.cs#L554
Member 'ReadEntryAsync' does not access instance data and can be marked as static (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1822)
|
The logs for this run have expired and are no longer available.
Loading