Skip to content

1.1.4

1.1.4 #31

Triggered via release January 22, 2024 11:33
@kbeaugrandkbeaugrand
published 1.1.4
Status Success
Total duration 43s
Artifacts

publish.yml

on: release
Matrix: Publish
Fit to window
Zoom out
Zoom in

Annotations

20 warnings
Publish (Connectors.Memory.SqlServer): src/Connectors.Memory.SqlServer/ISqlServerClient.cs#L77
The EnumeratorCancellationAttribute applied to parameter 'cancellationToken' will have no effect. The attribute is only effective on a parameter of type CancellationToken in an async-iterator method returning IAsyncEnumerable
Publish (Connectors.Memory.SqlServer): src/Connectors.Memory.SqlServer/SqlServerMemoryStore.cs#L31
Cannot convert null literal to non-nullable reference type.
Publish (Connectors.Memory.SqlServer): src/Connectors.Memory.SqlServer/SqlServerClient.cs#L466
Missing XML comment for publicly visible type or member 'SqlServerClient.Dispose()'
Publish (Connectors.Memory.SqlServer): src/Connectors.Memory.SqlServer/SqlServerMemoryStore.cs#L230
Missing XML comment for publicly visible type or member 'SqlServerMemoryStore.Dispose()'
Publish (Connectors.Memory.SqlServer): src/Connectors.Memory.SqlServer/SqlServerMemoryStore.cs#L183
In externally visible method 'Task<string> SqlServerMemoryStore.UpsertAsync(string collectionName, MemoryRecord record, CancellationToken cancellationToken = default(CancellationToken))', validate parameter 'record' is non-null before using it. If appropriate, throw an 'ArgumentNullException' when the argument is 'null'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1062)
Publish (Connectors.Memory.SqlServer): src/Connectors.Memory.SqlServer/SqlServerMemoryStore.cs#L197
In externally visible method 'IAsyncEnumerable<string> SqlServerMemoryStore.UpsertBatchAsync(string collectionName, IEnumerable<MemoryRecord> records, CancellationToken cancellationToken = default(CancellationToken))', validate parameter 'records' is non-null before using it. If appropriate, throw an 'ArgumentNullException' when the argument is 'null'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1062)
Publish (Connectors.Memory.SqlServer): src/Connectors.Memory.SqlServer/SqlServerMemoryStore.cs#L204
Member 'GetMemoryRecordFromEntry' does not access instance data and can be marked as static (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1822)
Publish (Connectors.Memory.SqlServer): src/Connectors.Memory.SqlServer/SqlServerClient.cs#L461
In method 'NormalizeIndexName', replace the call to 'ToLowerInvariant' with 'ToUpperInvariant' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1308)
Publish (Connectors.Memory.SqlServer): src/Connectors.Memory.SqlServer/SqlServerClient.cs#L430
Member 'ReadEntryAsync' does not access instance data and can be marked as static (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1822)
Publish (Connectors.Memory.SqlServer): src/Connectors.Memory.SqlServer/ISqlServerClient.cs#L77
The EnumeratorCancellationAttribute applied to parameter 'cancellationToken' will have no effect. The attribute is only effective on a parameter of type CancellationToken in an async-iterator method returning IAsyncEnumerable
Publish (KernelMemory.MemoryStorage.SqlServer): src/KernelMemory.MemoryStorage.SqlServer/SqlServerMemory.cs#L596
Missing XML comment for publicly visible type or member 'SqlServerMemory.Dispose()'
Publish (KernelMemory.MemoryStorage.SqlServer): src/KernelMemory.MemoryStorage.SqlServer/SqlServerMemory.cs#L26
Provide an overridable implementation of Dispose(bool) on 'SqlServerMemory' or mark the type as sealed. A call to Dispose(false) should only clean up native resources. A call to Dispose(true) should clean up both managed and native resources. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1063)
Publish (KernelMemory.MemoryStorage.SqlServer): src/KernelMemory.MemoryStorage.SqlServer/KernelMemoryBuilderExtensions.cs#L30
In externally visible method 'IKernelMemoryBuilder KernelMemoryBuilderExtensions.WithSqlServerMemoryDb(IKernelMemoryBuilder builder, string connString)', validate parameter 'builder' is non-null before using it. If appropriate, throw an 'ArgumentNullException' when the argument is 'null'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1062)
Publish (KernelMemory.MemoryStorage.SqlServer): src/KernelMemory.MemoryStorage.SqlServer/KernelMemoryBuilderExtensions.cs#L19
In externally visible method 'IKernelMemoryBuilder KernelMemoryBuilderExtensions.WithSqlServerMemoryDb(IKernelMemoryBuilder builder, SqlServerConfig config)', validate parameter 'builder' is non-null before using it. If appropriate, throw an 'ArgumentNullException' when the argument is 'null'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1062)
Publish (KernelMemory.MemoryStorage.SqlServer): src/KernelMemory.MemoryStorage.SqlServer/SqlServerMemory.cs#L154
In externally visible method 'Task SqlServerMemory.DeleteAsync(string index, MemoryRecord record, CancellationToken cancellationToken = default(CancellationToken))', validate parameter 'record' is non-null before using it. If appropriate, throw an 'ArgumentNullException' when the argument is 'null'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1062)
Publish (KernelMemory.MemoryStorage.SqlServer): src/KernelMemory.MemoryStorage.SqlServer/SqlServerMemory.cs#L414
In externally visible method 'Task<string> SqlServerMemory.UpsertAsync(string index, MemoryRecord record, CancellationToken cancellationToken = default(CancellationToken))', validate parameter 'record' is non-null before using it. If appropriate, throw an 'ArgumentNullException' when the argument is 'null'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1062)
Publish (KernelMemory.MemoryStorage.SqlServer): src/KernelMemory.MemoryStorage.SqlServer/SqlServerMemory.cs#L590
In method 'NormalizeIndexName', replace the call to 'ToLowerInvariant' with 'ToUpperInvariant' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1308)
Publish (KernelMemory.MemoryStorage.SqlServer): src/KernelMemory.MemoryStorage.SqlServer/SqlServerMemory.cs#L596
Modify 'SqlServerMemory.Dispose' so that it calls Dispose(true), then calls GC.SuppressFinalize on the current object instance ('this' or 'Me' in Visual Basic), and then returns (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1063)
Publish (KernelMemory.MemoryStorage.SqlServer): src/KernelMemory.MemoryStorage.SqlServer/SqlServerMemory.cs#L596
Change SqlServerMemory.Dispose() to call GC.SuppressFinalize(object). This will prevent derived types that introduce a finalizer from needing to re-implement 'IDisposable' to call it. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1816)
Publish (KernelMemory.MemoryStorage.SqlServer): src/KernelMemory.MemoryStorage.SqlServer/SqlServerMemory.cs#L555
Member 'ReadEntryAsync' does not access instance data and can be marked as static (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1822)