Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Brackets around Create Index Name for proper name handling #155

Merged
merged 1 commit into from
Jan 6, 2025
Merged

Add Brackets around Create Index Name for proper name handling #155

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Connectors.Memory.SqlServer/SqlServerClient.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@
);

IF OBJECT_ID(N'{this._configuration.Schema}.IXC_{$"{this._configuration.EmbeddingsTableName}_{collectionName}"}', N'U') IS NULL
CREATE CLUSTERED COLUMNSTORE INDEX IXC_{$"{this._configuration.EmbeddingsTableName}_{collectionName}"}
CREATE CLUSTERED COLUMNSTORE INDEX [IXC_{$"{this._configuration.EmbeddingsTableName}_{collectionName}"}]
ON {this.GetFullTableName($"{this._configuration.EmbeddingsTableName}_{collectionName}")};";

command.Parameters.AddWithValue("@collectionName", collectionName);
Expand Down Expand Up @@ -463,7 +463,7 @@
return index;
}

public void Dispose()

Check warning on line 466 in src/Connectors.Memory.SqlServer/SqlServerClient.cs

View workflow job for this annotation

GitHub Actions / build 

Missing XML comment for publicly visible type or member 'SqlServerClient.Dispose()'
{
if (this._connection != null)
{
Expand Down
Loading