Feature/130 integration queries #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…plementations and renamed integration queries directory due to renaming, the query_builder is now importable
…sed data integration this implementations uses a query builder to generate SPARQL UPDATE queries on the fly based on a configuration instead of reading already serialized SPARQL queries from disk
The only thing missing are the handling of the respective own data source ID via dcterms:identifier and adding the binding using the UUID function
…n of records Syntax errors in the genreated SPARQL queries were fixed, they still don't seem to work though which requires investigation why
…uality library authorities
…QL queries works The number of translations remained the same, there are more contributors but this is due to the fact that we have less 'missing name' contributors (20 instead of 280)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature replaces the implementation of the data integration based on already serialized SPARQL queries with an implementation based on dynamically generated SPARQL queries.
This will ease the integration of new data sources, because instead of manually creating several new SPARQL queries (or copy/paste and adapt existing ones) which is prone to error, only a lightweight CSV configuration needs to be given and the queries to integrate a data source are created automatically on-demand.
Using the new implementation, more contributors are listed in the corpus Excel file, but this is due to the fact that the old implementation apparently could not fetch all contributor label properties properly. Hence many translations contained contributors with "missing name" which resulted in less contributors for the actual person contributors list.
We noticed that the test coverage is not satisfying yet, but this can be tackled in a later issue: #137