Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove/unit of measurement #56

Closed
wants to merge 2 commits into from
Closed

Conversation

disforw
Copy link
Collaborator

@disforw disforw commented Aug 31, 2023

This PR will remove all need for us to determine what to display for the user. By reading the unit given to us by the API and telling HA what the NATIVE reading is, HA will automatically calculate and display the proper unit to the user.

@kdeyev
Copy link
Owner

kdeyev commented Aug 31, 2023

You may want to install pre-commit on your local dev environment. It will fix minor code styling issued before the commit, so the git pipeline will not fail then.

@disforw
Copy link
Collaborator Author

disforw commented Aug 31, 2023

Interestingly, I don’t usually work out of a “dev environment”. Most of my “play time” is spent on my ipad while sitting right on the couch working right in the browser. 🙈 I hope thats OK. I’ll try and work more in a teamate fashion using branches and PRs instead of straight master branch editing….

@kdeyev
Copy link
Owner

kdeyev commented Aug 31, 2023

No problem at all, working from the browser should not be a problem.
I meant the GitHub check failures. The checks are mostly complaining about minor issues like extra space somewhere or unused import.
Let me think If I can fix it automatically since you are working from the browser.

@disforw
Copy link
Collaborator Author

disforw commented Sep 7, 2023

Working this in #64

@disforw disforw closed this Sep 7, 2023
@disforw disforw deleted the remove/unit-of-measurement branch September 30, 2023 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants