fix updating viewer_item for all viewers

kecnry · Nov 3, 2023 · c33b10e · c33b10e
1 parent 47d3fc1
commit c33b10e
Showing 1 changed file with 16 additions and 23 deletions.
diff --git a/jdaviz/configs/imviz/helper.py b/jdaviz/configs/imviz/helper.py
@@ -656,37 +656,30 @@ def link_image_data(app, link_type='pixels', wcs_fallback_scheme=None, wcs_use_a
 
     app._link_type = link_type
     app._wcs_use_affine = wcs_use_affine
-    # TODO: this all needs to be generalized to work on multiple viewers
-    # (including determining refdata)
-    viewer_ref = app._jdaviz_helper.default_viewer.reference
-    viewer_item = app._get_viewer_item(viewer_ref)
-
-    viewer_item['reference_data_label'] = refdata.label
-    viewer_item['linked_by_wcs'] = link_type == 'wcs'
-
-    if link_plugin is not None:
-        # Only broadcast after success.
-        app.hub.broadcast(LinkUpdatedMessage(link_type,
-                                             wcs_fallback_scheme == 'pixels',
-                                             wcs_use_affine,
-                                             sender=app))
-
-        if insert_base_wcs_layer:
-            # update all viewer items with reference data:
-            for viewer_id in app.get_viewer_ids():
-                viewer_item = app._get_viewer_item(viewer_id)
-                viewer_item['reference_data_label'] = refdata.label
-
-        # reset the progress spinner
-        link_plugin.linking_in_progress = False
 
     for viewer in app._viewer_store.values():
         wcs_linked = link_type == 'wcs'
         # viewer-state needs to know link type for reset_limits behavior
         viewer.state.linked_by_wcs = wcs_linked
         # also need to store a copy in the viewer item for the data dropdown to access
+        viewer_item = app._get_viewer_item(viewer.reference)
+
+        viewer_item['reference_data_label'] = refdata.label
         viewer_item['linked_by_wcs'] = wcs_linked
 
+        if insert_base_wcs_layer:
+            viewer_item['reference_data_label'] = refdata.label
+
         # if changing from one link type to another, reset the limits:
         if link_type != old_link_type:
             viewer.state.reset_limits()
+
+    if link_plugin is not None:
+        # Only broadcast after success.
+        app.hub.broadcast(LinkUpdatedMessage(link_type,
+                                             wcs_fallback_scheme == 'pixels',
+                                             wcs_use_affine,
+                                             sender=app))
+
+        # reset the progress spinner
+        link_plugin.linking_in_progress = False