fix: make the app full height in popout window (#12)

Use the new class that is also available in a Solara popout window. Keep the styling of #popout-widget-container for backward compatibility with ipypopout<1.3.0.
kecnry · Jul 30, 2024 · caf9dbb · caf9dbb
1 parent 562888f
commit caf9dbb
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/jdaviz/main_styles.vue b/jdaviz/main_styles.vue
@@ -239,12 +239,16 @@ a:active {
   max-height: calc(100% - 48px);
 }
 
-#popout-widget-container .v-application.jdaviz {
+/* #popout-widget-container line can be removed once users use ipypopout >= 1.3.0 */
+#popout-widget-container .v-application.jdaviz,
+.jupyter-widgets-popout-container .v-application.jdaviz {
   min-height: 100vh;
   max-height: 100vh;
 }
 
-#popout-widget-container .jdaviz__content--not-in-notebook {
+/* #popout-widget-container line can be removed once users use ipypopout >= 1.3.0 */
+#popout-widget-container .jdaviz__content--not-in-notebook,
+.jupyter-widgets-popout-container .jdaviz__content--not-in-notebook {
   max-height: 100%;
 }
 

diff --git a/pyproject.toml b/pyproject.toml
@@ -21,7 +21,7 @@ dependencies = [
     "ipysplitpanes>=0.1.0",
     "ipygoldenlayout>=0.3.0",
     "ipywidgets>=8.0.6",
-    "solara>=1.32",
+    "solara>=1.36",
     "pyyaml>=5.4.1",
     "specutils>=1.15",
     "specreduce>=1.4.1",