Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: height and spacing #9

Merged
merged 2 commits into from
Jul 3, 2024

Conversation

mariobuikhuizen
Copy link

No description provided.

@mariobuikhuizen mariobuikhuizen requested a review from kecnry as a code owner July 2, 2024 12:00
@mariobuikhuizen mariobuikhuizen force-pushed the standalone-solara branch 3 times, most recently from c04e85f to f36fcdb Compare July 2, 2024 12:20
Copy link

codecov bot commented Jul 2, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.

Please upload report for BASE (standalone-solara@a829df0). Learn more about missing BASE report.

Files Patch % Lines
jdaviz/solara.py 33.33% 2 Missing ⚠️
jdaviz/core/launcher.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                 Coverage Diff                  @@
##             standalone-solara       #9   +/-   ##
====================================================
  Coverage                     ?   88.80%           
====================================================
  Files                        ?      112           
  Lines                        ?    17190           
  Branches                     ?        0           
====================================================
  Hits                         ?    15265           
  Misses                       ?     1925           
  Partials                     ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@kecnry kecnry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works like a charm - thanks! 🎉

@kecnry kecnry merged commit cbeede1 into kecnry:standalone-solara Jul 3, 2024
16 of 18 checks passed
kecnry pushed a commit that referenced this pull request Jul 9, 2024
* fix: height and spacing
* fix: height of launcher
kecnry pushed a commit that referenced this pull request Jul 30, 2024
* fix: height and spacing
* fix: height of launcher
kecnry pushed a commit that referenced this pull request Aug 15, 2024
* fix: height and spacing
* fix: height of launcher
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants