-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add python 3.12 to starters builds #219
Conversation
Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch
|
Yeah, https://docs.python.org/3.12/whatsnew/3.12.html#distutils |
|
Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com>
Adding
What do you think @ElenaKhaustova @astrojuanlu @noklam? |
Is this a build or project requirements? Usually |
@noklam just adding it to the |
After reading the JIRA issue, I think it's okay to included it in requirements.txt conditionally for >=3.12. It's a shame PySpark didn't support this. We should leave a comment in the requirements too. |
I agree with this, as it seems reasonable. We can also open a ticket along with leaving comments to update after |
All done! ✅ |
Motivation and Context
Noticed that 3.12 builds were missing!
How has this been tested?
Checklist