Fix extracting of org from org/repo name in workflow generating docs #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we've used `dest_org=${${{ inputs.destinationRepo }}%%/*}` which was
removing the longest part (separated by `/`) from the input. This wasn't what we
wanted in cases where the org name is longer than the repo name.
We're now changing the approach and we're using `dest_org=$(echo
${{ inputs.destinationRepo }} | cut -d'/' -f1)` command now. The `cut` command
is used to extract sections from lines of files or strings. In this case, we're
using it to split the ${{ inputs.destinationRepo }} string on the `/` delimiter
and then selecting the first field (`-f1`) before the delimiter.
By using this approach, it doesn't matter if the first or second part is longer;
it will always extract the first part of the variable containing `/`.
pdyraga
approved these changes
Jun 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we've used
dest_org=${${{ inputs.destinationRepo }}%%/*}which was removing the longest part (separated by/) from the input. This wasn't what we wanted in cases where the org name is longer than the repo name. We're now changing the approach and we're usingdest_org=$(echo ${{ inputs.destinationRepo }} | cut -d'/' -f1)command now. Thecutcommand is used to extract sections from lines of files or strings. In this case, we're using it to split the ${{ inputs.destinationRepo }} string on the/delimiter and then selecting the first field (-f1) before the delimiter. By using this approach, it doesn't matter if the first or second part is longer; it will always extract the first part of the variable containing/.