Skip to content

Commit

Permalink
Don't run postinstall script separately from yarn install (#629)
Browse files Browse the repository at this point in the history
Background:
Previously we've been running postinstall script in a separate step from
the `yarn install` command. We've been doing that as a workaround for a
problem we had with the postinstall script in the
`@threshold-network/solidity-contracts` package (the script in that
package often randomly failed). Running `yarn upgrade` with
`--ignore-scripts` flag prevented the execution of postinstall script in
the main project and its depandencies. And running `yarn run
postinstall` after did execute the postinstall script in the main
project.

The change:
Recently we have refactored the `@threshold-network/solidity-contracts`
project and got rid of the problematic script. We can go back to
executing `yarn install` without the `--ignore-scripts` flag.

Ref:
threshold-network/solidity-contracts#142
threshold-network/solidity-contracts#143
threshold-network/token-dashboard#531
  • Loading branch information
dimpar authored Jun 9, 2023
2 parents 7f48d63 + 2c7c63e commit 66a04c6
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions monitoring/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,7 @@ COPY package.json yarn.lock ./
COPY tsconfig.json ./
COPY src ./src

RUN yarn install --frozen-lockfile --ignore-scripts
RUN yarn run postinstall
RUN yarn install --frozen-lockfile

RUN yarn build

Expand Down

0 comments on commit 66a04c6

Please sign in to comment.