Skip to content

Commit

Permalink
Rename fn that converts script to BTC address
Browse files Browse the repository at this point in the history
The `scriptPubKey` is a field specific to transaction outputs but
basically, this function converts any script to a Bitcoin address. Here
we make this function more generic and rename to
`createAddressFromOutputScript`.
  • Loading branch information
r-czajkowski committed Jul 12, 2023
1 parent 51a63a7 commit c6f94f6
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion typescript/src/bitcoin.ts
Original file line number Diff line number Diff line change
Expand Up @@ -633,7 +633,7 @@ export function createOutputScriptFromAddress(address: string): Hex {
* @param network Bitcoin network.
* @returns The Bitcoin address.
*/
export function getAddressFromScriptPubKey(
export function createAddressFromOutputScript(
scriptPubKey: string,
network: BitcoinNetwork = BitcoinNetwork.Mainnet
): string {
Expand Down
4 changes: 2 additions & 2 deletions typescript/test/bitcoin.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ import {
bitsToTarget,
targetToDifficulty,
createOutputScriptFromAddress,
getAddressFromScriptPubKey,
createAddressFromOutputScript,
} from "../src/bitcoin"
import { calculateDepositRefundLocktime } from "../src/deposit"
import { BitcoinNetwork } from "../src/bitcoin-network"
Expand Down Expand Up @@ -493,7 +493,7 @@ describe("Bitcoin", () => {
btcAddresses[bitcoinNetwork as keyof typeof btcAddresses]
).forEach(([addressType, { address, scriptPubKey }]) => {
it(`should return correct ${addressType} address`, () => {
const result = getAddressFromScriptPubKey(
const result = createAddressFromOutputScript(
scriptPubKey,
bitcoinNetwork === "mainnet"
? BitcoinNetwork.Mainnet
Expand Down

0 comments on commit c6f94f6

Please sign in to comment.