Deployment script for WalletCoordinator upgrade #643
Merged
+98
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We add a script for WalletCoordinator contract upgrade. The current WalletCoordinator contract deployed to mainnet is owned by Threshold Council, so it cannot be upgraded right away by the deployer. The deployer will deploy a fresh WalletCoordinator contract implementation, then Threshold Council need to execute transactions to upgrade the WalletCoordinator proxy to the new implementation and set the initial values for newely added parameters.
pdyraga
reviewed
Jul 5, 2023
Comment on lines
+34
to
+63
| const upgradeTxData = await proxyAdmin.interface.encodeFunctionData( | ||
| "upgrade", | ||
| [proxyDeployment.address, newImplementationAddress] | ||
| ) | ||
|
|
||
| deployments.log( | ||
| `proxy admin owner ${proxyAdminOwner} is required to upgrade proxy implementation with transaction:\n` + | ||
| `\t\tfrom: ${proxyAdminOwner}\n` + | ||
| `\t\tto: ${proxyAdmin.address}\n` + | ||
| `\t\tdata: ${upgradeTxData}` | ||
| ) | ||
|
|
||
| // Assemble parameters upgrade transaction. | ||
| const walletCoordinator: WalletCoordinator = | ||
| await helpers.contracts.getContract("WalletCoordinator") | ||
|
|
||
| const walletCoordinatorOwner = await walletCoordinator.owner() | ||
|
|
||
| const updateRedemptionProposalParametersTxData = | ||
| walletCoordinator.interface.encodeFunctionData( | ||
| "updateRedemptionProposalParameters", | ||
| [7200, 600, 7200, 20, 20000] | ||
| ) | ||
|
|
||
| deployments.log( | ||
| `WalletCoordinator owner ${walletCoordinatorOwner} is required to update redemption proposal parameters with transaction:\n` + | ||
| `\t\tfrom: ${walletCoordinatorOwner}\n` + | ||
| `\t\tto: ${walletCoordinator.address}\n` + | ||
| `\t\tdata: ${updateRedemptionProposalParametersTxData}` | ||
| ) |
There was a problem hiding this comment.
It is nice to be able to double-check the data in the simulation but worth noting, this part is not strictly required.
There was a problem hiding this comment.
Definitely, we will simulate with Tenderly first. But we need the new contract to be deployed for that.
pdyraga
approved these changes
Jul 5, 2023
13 tasks
deployment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We add a script for WalletCoordinator contract upgrade.
The current WalletCoordinator contract deployed to mainnet is owned by Threshold Council, so it cannot be upgraded right away by the deployer.
The deployer will deploy a fresh WalletCoordinator contract implementation, then Threshold Council needs to execute transactions to upgrade the WalletCoordinator proxy to the new implementation and set the initial values for newly added parameters.
Refs: #641