Add function that returns Bitcoin address from output script #646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the new function that returns the Bitcoin address based on the script pub key placed on the output of a Bitcoin transaction.
r-czajkowski
requested review from
pdyraga,
nkuba,
lukasz-zimnoch,
michalsmiarowski and
tomaszslabon
3 tasks
r-czajkowski
changed the title
getAddressFromScriptPubKey fngetAddressFromScriptPubKey function
The `scriptPubKey` is a field specific to transaction outputs but basically, this function converts any script to a Bitcoin address. Here we make this function more generic and rename to `createAddressFromOutputScript`.
Rename `scriptPubKey` to `script` and update docs. The `scriptPubKey` is a field specific to transaction outputs but basically, this function converts any script to a Bitcoin address. Here we also update type of this param to `Hex` instead of `string`.
lukasz-zimnoch
approved these changes
Jul 12, 2023
r-czajkowski
changed the title
getAddressFromScriptPubKey function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on: #632Add the new function that returns the Bitcoin address based on the script pub key placed on the output of a Bitcoin transaction.