-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added additional system test scenario #654
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r-czajkowski
requested changes
Jul 13, 2023
tomaszslabon
force-pushed
the
system-test-update-additional-scenario
branch
3 times, most recently
from
July 18, 2023 12:51
f6117bc
to
ee951b9
Compare
tomaszslabon
force-pushed
the
system-test-update-additional-scenario
branch
from
July 18, 2023 12:58
ee951b9
to
b55734c
Compare
tomaszslabon
force-pushed
the
system-test-update-additional-scenario
branch
2 times, most recently
from
July 18, 2023 21:08
d215d83
to
f81d29f
Compare
tomaszslabon
force-pushed
the
system-test-update-additional-scenario
branch
from
July 18, 2023 21:11
f81d29f
to
580040f
Compare
r-czajkowski
approved these changes
Jul 31, 2023
dimpar
approved these changes
Aug 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds additional system tests scenario in which deposit is revealed with a vault.
This PR is a follow-up to #647.
In the already existing scenario, the depositor revealed their deposit without specifying the vault.
As a result the depositor had their blance increased in the Bank.
In the new scenario the depositor reveals their deposit and provides the vault address.
As a result TBTC tokens are minted for the depositor.