Expose past redemption requested events getter #677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Here we expose the `Bridge.getRedemptionRequestedEvents` method that allows fetching past redemption requested events from the `Bridge` contract.
r-czajkowski
reviewed
Aug 2, 2023
Comment on lines
+775
to
+779
| const events: EthersEvent[] = await this.getEvents( | ||
| "RedemptionRequested", | ||
| options, | ||
| ...filterArgs | ||
| ) |
There was a problem hiding this comment.
Probably won't work if we want to filter events by the indexed walletPubKeyHash param. See ethers-io/ethers.js#4244 - I ran into this issue in T daap with ethers v5.4.7. Here we use v5.5.2 but I think this problem still exists in this version. As a workaround, you can take a look at this.
There was a problem hiding this comment.
Added a note about that: cce9d9c. Thanks!
r-czajkowski
approved these changes
Aug 2, 2023
pdyraga
added a commit
that referenced
this pull request
Aug 3, 2023
Refs: keep-network/keep-core#3664 Depends on: #677 This changeset adds redemptions to the monitoring system. Specifically, two new system events are supported now: ### Redemption requested An **informational system event** indicating that a new redemption was requested from the on-chain Bridge contract. This event is directly sent to Discord as a notification that does not require any action. ### Large redemption requested A **warning system event** indicating that a large redemption was requested from the on-chain Bridge contract. This event is sent to Sentry hub and should get team’s attention. The default action is making sure that the redemption is not a result of a malicious action, and if not, that the redemption is handled correctly by the system.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: keep-network/keep-core#3664
Here we expose the
Bridge.getRedemptionRequestedEventsmethod that allows fetching past redemption requested events from theBridgecontract.