Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deployment scripts for Solana #688

Merged
merged 19 commits into from
Aug 21, 2023
Merged

Deployment scripts for Solana #688

merged 19 commits into from
Aug 21, 2023

Conversation

dimpar
Copy link
Contributor

@dimpar dimpar commented Aug 8, 2023

These changes include bash scripts and init scripts that are used to build, deploy and init tbtc & wormhole_gateway programs on Solana.

Usage:
./scripts/deploy.sh - due to the nature of deployment on Solana, it is very tricky to do everything in one shot. Please read the comments. Certain parts of this script need to be uncommented one by one to deploy programs properly

./scripts/transfer_authority.sh - same as above, please read the comments and uncomment the parts one by one. For mainnet use only.

tbtc on mainnet https://solscan.io/account/Gj93RRt6QB7FjmyokAD5rcMAku7pq3Fk2Aa8y6nNbwsV
wormhole_gateway on mainnet https://solscan.io/account/87MEvHZCXE3ML5rrmh5uX1FbShHmRXXS32xJDGbQ7h5t

Commented-out commands in the bash scripts are intentional because it is tricky to deploy on Solana in one shot.

These changes include bash scripts and typescripts that are used to
build and deploy programs on Solana. We also need to initalize these
programs. More init work to come..
@dimpar dimpar requested a review from a5-pickle August 8, 2023 14:02
Copy link
Contributor

@a5-pickle a5-pickle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would leverage the Makefile more. But if it's easier for you to add commands to Anchor.toml, that looks fine to me, too.

cross-chain/solana/scripts/deploy.sh Outdated Show resolved Hide resolved
cross-chain/solana/scripts/deploy.sh Outdated Show resolved Hide resolved
cross-chain/solana/scripts/deploy.sh Outdated Show resolved Hide resolved
cross-chain/solana/migrations/deploy.ts Outdated Show resolved Hide resolved
cross-chain/solana/Anchor.toml Outdated Show resolved Hide resolved
@dimpar dimpar marked this pull request as ready for review August 11, 2023 09:40
@dimpar dimpar self-assigned this Aug 11, 2023
@dimpar dimpar requested a review from eth-r August 11, 2023 09:40
@dimpar dimpar changed the title Drafting deployment scripts for Solana Deployment scripts for Solana Aug 11, 2023
"scripts": {
"build": "anchor build",
Copy link
Contributor

@a5-pickle a5-pickle Aug 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would get rid of this since you have the Makefile specifying the build command.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, done in feb345b

"lint:fix": "prettier */*.js \"*/**/*{.js,.ts}\" -w",
"lint": "prettier */*.js \"*/**/*{.js,.ts}\" --check"
"lint": "prettier */*.js \"*/**/*{.js,.ts}\" --check",
"test": "anchor test"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would get rid of this, too, since you have the Makefile specifying the test command.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, done in feb345b

a5-pickle
a5-pickle previously approved these changes Aug 14, 2023
Copy link
Contributor

@a5-pickle a5-pickle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just left a few notes for someone else wanting to do clean up in the package.json file.

Also if the shell scripts are supposed to have commented-out commands, everything looks good.

@pdyraga pdyraga enabled auto-merge August 21, 2023 12:46
@pdyraga pdyraga merged commit 59af02b into main Aug 21, 2023
38 checks passed
@pdyraga pdyraga deleted the tbtc-solana-deployment branch August 21, 2023 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants