Support deployment on Sepolia #691
Conversation
The Görli testnet currently used by Threshold/Keep for development purposes is planned to become deprecated with the end of year 2023. The testnet that is planned to replace it is called [Holešky](https://github.com/eth-clients/holesky), however it's not yet available - it's planned it will become widely accessible on Oct 1, 2023 ([source](https://everstake.one/blog/new-ethereum-testnet-holesky-all-you-need-to-know-now)). Switching our infrastructure to support new testnet is quite time consuming, so moving directly from Görli to Holešky may be quite risky, especially if there would be some delays in the date of Holešky genesis (not meeting the planned timelines is not a rare occurrence in the Ethereum space). As a solution, we decided to switch first to another testnet that is currently live - Sepolia. This testnet's EOL is planned for 2026, which gives us plenty of time to move to Holešky before Sepolia gets deprecated.
deployment
|
Solidity API documentation preview available in the artifacts of the https://github.com/keep-network/tbtc-v2/actions/runs/6082976303 check. |
|
Solidity API documentation preview available in the artifacts of the https://github.com/keep-network/tbtc-v2/actions/runs/6084041135 check. |
michalinacienciala
force-pushed
the
support-sepolia
branch
from
16fe873
to
b6b2e2e
Compare
|
Solidity API documentation preview available in the artifacts of the https://github.com/keep-network/tbtc-v2/actions/runs/6084123173 check. |
michalinacienciala
force-pushed
the
support-sepolia
branch
from
b6b2e2e
to
21dc504
Compare
|
Solidity API documentation preview available in the artifacts of the https://github.com/keep-network/tbtc-v2/actions/runs/6094247465 check. |
.github/workflows/contracts.yml
Outdated
| # Use fake ternary expressions to decide which credentials to use, | ||
| # depending on chosen environment. Note: if `GOERLI...` credentials | ||
| # are empty, the expressions will be evaluated to the `SEPOLIA...` | ||
| # ones. |
There was a problem hiding this comment.
Same question as in threshold-network/solidity-contracts#151 (comment)
There is no scenario were we wouldn't need to provide an `environment` when manually triggering the workflow run.
We don't need to differenciate between Sepolia and Goerli secrets storing private keys of the deployers - in both cases we're using the same deployer address.
solidity/hardhat.config.ts
Outdated
| // We are not setting SPV maintainer for mainnet in deployment scripts. | ||
| }, | ||
| coordinator: { | ||
| default: 9, | ||
| goerli: "0x4815cd81fFc21039a25aCFbD97CE75cCE8579042", | ||
| // TODO: add one for sepolia |
There was a problem hiding this comment.
@lukasz-zimnoch, I see the address set for goerli the address of the Keep Maintainer Bot stored in 1password. Should I use the same for sepolia?
There was a problem hiding this comment.
Yeah, we can use the same as the private key is under our control.
There was a problem hiding this comment.
Set, see 2a27c65.
|
Solidity API documentation preview available in the artifacts of the https://github.com/keep-network/tbtc-v2/actions/runs/6247290843 check. |
|
Ready for review (but not for merge). |
The Görli testnet currently used by Threshold/Keep for development purposes is planned to become deprecated with the end of year 2023. The testnet that is planned to replace it is called [Holešky](https://github.com/eth-clients/holesky), however it's not yet available - it's planned it will become widely accessible on Oct 1, 2023 ([source](https://everstake.one/blog/new-ethereum-testnet-holesky-all-you-need-to-know-now)). Switching our infrastructure to support new testnet is quite time consuming, so moving directly from Görli to Holešky may be quite risky, especially if there would be some delays in the date of Holešky genesis (not meeting the planned timelines is not a rare occurrence in the Ethereum space). As a solution, we decided to switch first to another testnet that is currently live - Sepolia. This testnet's EOL is planned for 2026, which gives us plenty of time to move to Holešky before Sepolia gets deprecated. Refs: threshold-network/solidity-contracts#150 keep-network/ci#48 threshold-network/solidity-contracts#151 keep-network/tbtc-v2#691 threshold-network/token-dashboard#605 - [ ] Update `TESTNET_ETH_CONTRACT_OWNER_PRIVATE_KEY` so that it is prefixed with `0x`
The address is an address of the Keep Maintainer Bot.
|
Solidity API documentation preview available in the artifacts of the https://github.com/keep-network/tbtc-v2/actions/runs/6626592332 check. |
|
Solidity API documentation preview available in the artifacts of the https://github.com/keep-network/tbtc-v2/actions/runs/6627581364 check. |
The Görli testnet currently used by Threshold/Keep for development purposes is
planned to become deprecated with the end of year 2023. The testnet that is
planned to replace it is called
Holešky, however it's not yet
available - it's planned it will become widely accessible on Oct 1, 2023
(source).
Switching our infrastructure to support new testnet is quite time consuming, so
moving directly from Görli to Holešky may be quite risky, especially if there
would be some delays in the date of Holešky genesis (not meeting the planned
timelines is not a rare occurrence in the Ethereum space). As a solution, we
decided to switch first to another testnet that is currently live - Sepolia.
This testnet's EOL is planned for 2026, which gives us plenty of time to move to
Holešky before Sepolia gets deprecated.
Refs:
threshold-network/solidity-contracts#150
keep-network/ci#48
threshold-network/solidity-contracts#151
keep-network/keep-core#3706
threshold-network/token-dashboard#605