Add bitcoinjs-lib dependency
#696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomaszslabon
requested review from
lukasz-zimnoch,
michalsmiarowski and
r-czajkowski
tomaszslabon
force-pushed
the
install-bitcoinjs-lib
branch
from
bbfa3c6
to
e019dd1
Compare
lukasz-zimnoch
approved these changes
Sep 27, 2023
lukasz-zimnoch
added a commit
that referenced
this pull request
Sep 28, 2023
Depends on: #696. Refs: #695. This PR replaces the `bcoin` library with `bitcoinjs-lib` for deposit sweep transactions. The `bcoin` library was removed from `deposit-sweep.ts`. After this update, deposit sweep generally works in the same way as before. The only difference is that transaction inputs are always added in the same order: - main UTXO is added first - deposit inputs are added in the same order as the provided UTXOs. Before this change the inputs could be rearranged by the `bcoin` library.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: #695.
In this PR
bitcoinjs-liblibrary was added totbtc-v2.ts.Since there is a node version conflict between the newest
bitcoinjs-lib(requiresnode 16or later) andtbt-v2.ts(requiresnode 14), an older version ofbitcoinjs-libwas added(6.0.2).Once we get rid of
bcoinwe can updatebitcoinjs-libto its newest version as it should be possible to use node 16 withtbtc-v2.ts.I verified that the library was successfully installed.