Add Sepolia / Base Sepolia support for Base cross-chain #742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Goerli testnet currently used by Threshold/Keep for development purposes is planned to become deprecated with the end of year 2023. The testnet that was created to replace it is called [Holešky](https://github.com/eth-clients/holesky), however it will take some time until it gets integrated with by some of the projects we rely on. As a solution, we decided to switch first to another testnet that is currently live - Sepolia. This testnet's EOL is planned for 2026, which gives us plenty of time to move to Holešky before Sepolia gets deprecated. Until Görli is not dead we want to support both testnets. The Goerli -> Sepolia migration means that also L2 testnet basing on Goerli (Base Goerli) needs to be migrated to Sepolia-based chain (Base Sepolia). At the moment Base Sepolia is not supported by Wormhole, so deployment of our contracts on that testnet is yet not possible. But we're already adding changes that prepare us for the moment when it will be supported. Once support is confirmed, we'll need to verify if `wormholeChainID` we use in the config is correct for the testnet.
deployment
|
I've asked Wormhole support if they plan to deploy their contracts on Base Sepolia: https://discord.com/channels/856079283104251944/857225885231611935/1171840544364822628, will let here know once I have some more info. |
99 tasks
Earlier Basescan did not support Base Sepolia. Now that this testnet is supported there, we can change configuration to use Basescan instead of Blockscout (Basescan is what we use for other networks as well).
michalinacienciala
force-pushed
the
sepolia-support-base
branch
from
44f7de1
to
dea5b53
Compare
Wormhole has added support for Arbitrum Sepolia, Base Sepolia and Optimism Sepolia testnets. We want to modify the config of our deployment scripts so that deployment on Sepolia-based L2s would be possible. As the Chain IDs for Wormhole Sepolia-based networks differ from from IDs for Mainnet and Goerli-based testnets, we need to set the right value of `...WormholeChainID` constants for the the right network we're deploying to.
michalinacienciala
force-pushed
the
sepolia-support-base
branch
from
dea5b53
to
9d8a070
Compare
Comment on lines
+14
to
17
| // This ID is valid for both Polygonn Goerli-based Testnet (Mumbai) and | ||
| // Mainnet. Wormhole does not support the Sepolia-based Amoy Testnet yet. | ||
| // TODO: Update the ID once the support is added. | ||
| const polygonWormholeChainID = 5 |
There was a problem hiding this comment.
Not sure how the deploy on baseSepolia will behave when the polygonWormholeChainID does point to the value which is good for Mumbai and Polygon Mainnet, but not for Sepolia--based Amoy... Should I skip this script for now?
There was a problem hiding this comment.
Until new Polygon testnet is supported by Wormhole, we can skip this script during deploy.
Adding Sepolia-related contracts needed for deployment on `baseSepolia` network: * `external/baseSepolia/BaseTokenBridge.json` - address taken from https://docs.wormhole.com/wormhole/blockchain-environments/evm#testnet-contracts-base-sepolia-84532 * `external/baseSepolia/SolanaWormholeGateway.json` - used the same value as in `baseGoreli` * `external/sepolia/TokenBridge.json` - address taken from https://docs.wormhole.com/wormhole/blockchain-environments/evm#testnet-contracts-sepolia-11155111 NOT included in this commit (but needed for the deployment): * `external/baseSepolia/BaseWormholeTBTC.json` - in order to get the address we need to perform attestation of the Ethereum Sepolia TBTC token on Base Sepolia (but atm Base Sepolia is not available on the list of target networks on https://wormhole-foundation.github.io/example-token-bridge-ui/#/register)
Open
17 tasks
Locally deployed portal was used to register TBTC.
We're adding artifacts for contracts deployed to Base Sepolia network.
|
Tested on a local deployment of the Wormhole portal ( Ethereum Sepolia -> Base Sepolia (0.05 tBTC successfully bridged):
Base Sepolia -> Ethereum Sepolia (0.05 tBTC successfully bridged): |
|
We've deployed the contracts on Base Sepolia and published a package: @keep-network/tbtc-v2-base@1.1.0-sepolia.0 We've registered gateways of other L2s in Wormhole Portal and tested bridging between the networks: Sepolia Base > Sepolia Arbitrum
Sepolia Arbitrum > Sepolia Base
Sepolia Base > Sepolia Optimism
Sepolia Optimism > Sepolia Base |
lukasz-zimnoch
approved these changes
Feb 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Goerli testnet currently used by Threshold/Keep for development purposes was planned to become deprecated with the end of year 2023. Although it's already 2024, the testnet is still live, but it will loose validators over the time and may become unusable at some point. The testnet that was created to replace it is called
Holešky, however it will take some time until it gets integrated with by some of the projects we rely on. As a solution, we decided to switch first to another testnet that is currently live - Sepolia. This testnet's EOL is planned for 2026, which gives us plenty of time to move to Holešky before Sepolia gets deprecated.
The Goerli -> Sepolia migration means that also L2 testnet based on Goerli (Base Goerli) needs to be migrated to Sepolia-based chain (Base Sepolia). In this PR we're adjusting the config used to deploy testnet contracts in the
@keep-network/tbtc-v2-arbitrumproject. After the update, both deploy tobaseGoerliandbaseSepolianetworks will be supported (we may removebaseGoerlisupport once we're sure thebaseSepoliadeployment works as expected).TODO
external/baseSepolia/BaseWormholeTBTC.json- in order to get the address we need to perform attestation of the Ethereum Sepolia TBTC token on Base Sepolia (but atm Base Sepolia is not available on the list of target networks on https://wormhole-foundation.github.io/example-token-bridge-ui/#/register)Ref: threshold-network/solidity-contracts#150